Skip to content

runtime: deprecate tcp detect and raise RST runtime guard#33633

Merged
adisuissa merged 1 commit intoenvoyproxy:mainfrom
botengyao:remove-tcp-rst-runtime-guard
Apr 18, 2024
Merged

runtime: deprecate tcp detect and raise RST runtime guard#33633
adisuissa merged 1 commit intoenvoyproxy:mainfrom
botengyao:remove-tcp-rst-runtime-guard

Conversation

@botengyao
Copy link
Copy Markdown
Member

@botengyao botengyao commented Apr 17, 2024

runtime: remove tcp detect and raise RST runtime guard introduced by #28817

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes: #33616
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Boteng Yao <boteng@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33633 was opened by botengyao.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #33633 was opened by botengyao.

see: more, trace.

@botengyao botengyao changed the title runtime: remove tcp detect and raise RST runtime guard runtime: deprecate tcp detect and raise RST runtime guard Apr 17, 2024
@botengyao botengyao marked this pull request as ready for review April 17, 2024 19:05
@botengyao
Copy link
Copy Markdown
Member Author

/assign @adisuissa

Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit 313b6fb into envoyproxy:main Apr 18, 2024
cainelli pushed a commit to cainelli/envoy that referenced this pull request Apr 18, 2024
…oyproxy#33633)

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_detect_and_raise_rst_tcp_connection deprecation

2 participants