xds: define precedence between TLS cert fields#33749
Merged
adisuissa merged 2 commits intoenvoyproxy:mainfrom Apr 24, 2024
Merged
xds: define precedence between TLS cert fields#33749adisuissa merged 2 commits intoenvoyproxy:mainfrom
adisuissa merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
|
@markdroth looks like a legitimate formatting error: s/precendence/precedence |
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Mark D. Roth <roth@google.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
Signed-off-by: Mark D. Roth <roth@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: api: define precedence between TLS cert fields
Additional Description: Instead of requiring fields to be mutually exclusive as was originally done in #17201, define precendence between them, to be consistent with the API guidance updated in #30851. Note that this should not affect Envoy's implementation, since Envoy does not yet support CertificateProviders.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A