listener: rename "sni_domains" to "server_names".#3454
Merged
Conversation
*Risk Level*: Low *Testing*: bazel test //test/... *Docs Changes*: Added *Release Notes*: Added Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
As mentioned by @ggreenway in #3217. |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
ggreenway
requested changes
May 21, 2018
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
I'm very much in favor of this change.
|
|
||
| std::vector<std::string> server_names(filter_chain_match.sni_domains().begin(), | ||
| filter_chain_match.sni_domains().end()); | ||
| std::vector<std::string> server_names; |
Member
There was a problem hiding this comment.
I think we should throw an exception if both sni_domains and server_names are non-empty (and document the behavior).
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
ggreenway
previously approved these changes
May 22, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, just small doc ask.
| // .. attention:: | ||
| // | ||
| // Deprecated. Use :ref:`server_names <envoy_api_field_listener.FilterChainMatch.server_names>` instead. | ||
| repeated string sni_domains = 1 [deprecated = true]; |
Member
There was a problem hiding this comment.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
This is ready to be merged. |
mattklein123
approved these changes
May 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Low
Testing: bazel test //test/...
Docs Changes: Added
Release Notes: Added
Signed-off-by: Piotr Sikora piotrsikora@google.com