Skip to content

Revert "conn pool: use hostnames of endpoints as SNI values (#34898)"#35212

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:revert-auto-sni-fail
Jul 17, 2024
Merged

Revert "conn pool: use hostnames of endpoints as SNI values (#34898)"#35212
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:revert-auto-sni-fail

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jul 16, 2024

This reverts commit 6db316f.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…xy#34898)"

This reverts commit 6db316f.

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #35212 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 16, 2024

@dmitriyilin
Copy link
Copy Markdown
Contributor

dmitriyilin commented Jul 16, 2024

Thanks, I will take a look. However, i will be out of office for the rest of this working week.

As a notice, I've experienced flakiness with some other integration tests in checks in my PR. On top of that, a check in current state is also failing due to a failing integration test. Is there a known issue with stability of integration tests?

Screenshot 2024-07-16 at 22 15 26

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 17, 2024

I've experienced flakiness with some other integration tests ... Is there a known issue with stability of integration tests?

its an ongoing challenge preventing, catching and fixing flakes - esp those caused by timeouts (in some runs/situations)

just as your PR got through by retesting it until the flakey test passed - so it is with other PRs - the issue/s introduced then affect other runs

while we try to be vigilant about this, its not easy - but we do give this more attention when we are preparing a release (as now)

there is a separate, (i believe) unrelated flake showing now

/retest

@phlax phlax enabled auto-merge (squash) July 17, 2024 07:36
@phlax phlax merged commit d84f707 into envoyproxy:main Jul 17, 2024
dmitriyilin added a commit to dmitriyilin/envoy that referenced this pull request Jul 23, 2024
…nvoyproxy#34898)" (envoyproxy#35212)"

This reverts commit d84f707.

Signed-off-by: Dmitriy Ilin <dmitry.m.ilyin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants