Skip to content

Upgrade absl.#3591

Merged
ggreenway merged 1 commit intoenvoyproxy:masterfrom
ggreenway:new-absl
Jun 12, 2018
Merged

Upgrade absl.#3591
ggreenway merged 1 commit intoenvoyproxy:masterfrom
ggreenway:new-absl

Conversation

@ggreenway
Copy link
Copy Markdown
Member

This fixes an ASAN failure when run in a certain environment, as described by
abseil/abseil-cpp#118. The failure was added by
#3558, which pulled in the same
static initializer as described in the original absl issue linked here.

Signed-off-by: Greg Greenway ggreenway@apple.com

title: one line description

Risk Level: Low

Testing: Existing tests pass, plus this change fixes my internal ASAN build that was broken

This fixes an ASAN failure when run in a certain environment, as described by
abseil/abseil-cpp#118. The failure was added by
envoyproxy#3558, which pulled in the same
static initializer as described in the original absl issue linked here.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
Copy link
Copy Markdown
Member Author

I needed a newer version of absl to get the fix for abseil/abseil-cpp#118. I took the latest build, but if someone has a reason not to use this, I think I could pick the build about a week newer than the currently selected version.

@ggreenway
Copy link
Copy Markdown
Member Author

cc @alyssawilk

@ggreenway ggreenway merged commit f832327 into envoyproxy:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants