Refactor dns cluster api by Stevenjin8 · Pull Request #36353 · envoyproxy/envoy

Stevenjin8 · 2024-09-26T16:04:45Z

TODO:

Create new DnsConfig proto
Update deprecation docs
Update strict dns cluster to consume new dns config
Update logical dns cluster to consume new dns config
Test changes

Commit Message: Refactor DNS cluster configuration in its own extension
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

repokitteh-read-only · 2024-09-26T16:04:50Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #36353 was opened by Stevenjin8.

see: more, trace.

repokitteh-read-only · 2024-09-26T16:04:55Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #36353 was opened by Stevenjin8.

see: more, trace.

Stevenjin8 · 2024-09-26T16:35:05Z

@markdroth @wbpcode Just wanted to check in that I'm going in the right direction

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

Stevenjin8 · 2024-10-02T14:45:26Z

@markdroth I would also appreciate some guidance on what you expect for testing.

mattklein123 · 2024-10-04T22:54:03Z

Sorry can you provide some context on this?

/wait

markdroth

@mattklein123 For context, see #35479 (comment).

@Stevenjin8, I'm not the right person to ask about testing for the Envoy implementation, so I'll let one of the Envoy maintainers do that. My feedback here is just on the xDS API changes.

Please let me know if you have any questions. Thanks!

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

Stevenjin8 · 2024-12-12T19:39:51Z

Forgot to merge main. Should be ready for another review now (even though not much changed)

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

Stevenjin8 · 2024-12-17T19:41:25Z

/retest

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

markdroth

Just one minor comment improvement needed -- otherwise, this looks great from an API perspective!

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

markdroth · 2024-12-18T19:17:37Z

This looks great from an API perspective!

/lgtm api

mattklein123

Thanks for slogging through!

The main idea here is tackling #37145 (which is a follow up from #36353). This approach simplifies the code merging the two current implementation of DNS cluster (logical and strict) by removing unnecessary logical DNS, as it can be treated as a special case of strict DNS. According to the documentation: _When using **strict DNS** service discovery, Envoy will continuously and asynchronously resolve the specified DNS targets. Each returned IP address in the DNS result will be considered an explicit host in the upstream cluster. This means that if the query returns three IP addresses, Envoy will assume the cluster has three hosts, and all three should be load balanced to. If a host is removed from the result Envoy assumes it no longer exists and will drain traffic from any existing connection pools_ _**Logical DNS** uses a similar asynchronous resolution mechanism to strict DNS. However, instead of strictly taking the results of the DNS query and assuming that they comprise the entire upstream cluster, a logical DNS cluster only uses the first IP address returned when a new connection needs to be initiated. Thus, a single logical connection pool may contain physical connections to a variety of different upstream hosts. Connections are never drained, including on a successful DNS resolution that returns 0 hosts._ --------- Signed-off-by: Gustavo <grnmeira@gmail.com>

The main idea here is tackling envoyproxy#37145 (which is a follow up from envoyproxy#36353). This approach simplifies the code merging the two current implementation of DNS cluster (logical and strict) by removing unnecessary logical DNS, as it can be treated as a special case of strict DNS. According to the documentation: _When using **strict DNS** service discovery, Envoy will continuously and asynchronously resolve the specified DNS targets. Each returned IP address in the DNS result will be considered an explicit host in the upstream cluster. This means that if the query returns three IP addresses, Envoy will assume the cluster has three hosts, and all three should be load balanced to. If a host is removed from the result Envoy assumes it no longer exists and will drain traffic from any existing connection pools_ _**Logical DNS** uses a similar asynchronous resolution mechanism to strict DNS. However, instead of strictly taking the results of the DNS query and assuming that they comprise the entire upstream cluster, a logical DNS cluster only uses the first IP address returned when a new connection needs to be initiated. Thus, a single logical connection pool may contain physical connections to a variety of different upstream hosts. Connections are never drained, including on a successful DNS resolution that returns 0 hosts._ --------- Signed-off-by: Gustavo <grnmeira@gmail.com> Signed-off-by: Elisha Ziskind <eziskind@google.com>

repokitteh-read-only Bot added the api label Sep 26, 2024

repokitteh-read-only Bot assigned mattklein123 Sep 26, 2024

Stevenjin8 force-pushed the refactor/dns-api branch 3 times, most recently from 072cab0 to e1a1e5f Compare September 26, 2024 16:29

Stevenjin8 mentioned this pull request Sep 26, 2024

dns: Create new field for delayed DNS resolution #35479

Closed

Stevenjin8 force-pushed the refactor/dns-api branch 2 times, most recently from a305ccc to 928ef02 Compare October 1, 2024 16:46

Stevenjin8 marked this pull request as ready for review October 1, 2024 16:47

Stevenjin8 requested review from alyssawilk and mattklein123 as code owners October 1, 2024 16:47

Stevenjin8 commented Oct 1, 2024

View reviewed changes

Comment thread source/common/upstream/upstream_impl.cc

Stevenjin8 commented Oct 1, 2024

View reviewed changes

Comment thread source/extensions/clusters/strict_dns/strict_dns_cluster.cc Outdated

Stevenjin8 force-pushed the refactor/dns-api branch from 928ef02 to 2f5e253 Compare October 1, 2024 16:59

Move cluster dns config and validate in strict dns clusters

9048a69

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

Stevenjin8 force-pushed the refactor/dns-api branch from 2f5e253 to 9048a69 Compare October 2, 2024 14:31

Stevenjin8 changed the title ~~Refactor/dns api~~ Refactor dns cluster api Oct 2, 2024

repokitteh-read-only Bot added the waiting label Oct 4, 2024

markdroth reviewed Oct 4, 2024

View reviewed changes

Roll back incompatible API changes

3917c63

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

Stevenjin8 requested review from RyanTheOptimist, abeyad, fredyw, soulxu and wbpcode as code owners October 10, 2024 19:54

Stevenjin8 requested a review from markdroth December 12, 2024 19:16

Better docs

bd0ae97

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

repokitteh-read-only Bot removed the waiting label Dec 12, 2024

Merge branch 'main' into refactor/dns-api

1ffdf41

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

second merge

aeb3302

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

mattklein123 previously approved these changes Dec 16, 2024

View reviewed changes

repokitteh-read-only Bot removed the api label Dec 16, 2024

mattklein123 enabled auto-merge (squash) December 16, 2024 22:40

mattklein123 added the waiting label Dec 17, 2024

third merge

0b816c6

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

auto-merge was automatically disabled December 17, 2024 15:51
Head branch was pushed to by a user without write access

Stevenjin8 dismissed mattklein123’s stale review via 0b816c6 December 17, 2024 15:51

repokitteh-read-only Bot added api and removed waiting labels Dec 17, 2024

Stevenjin8 added 3 commits December 17, 2024 17:56

update logical dns api

2a7832f

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

forgot one!

9b7927c

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

last one please

3078d7c

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

markdroth reviewed Dec 18, 2024

View reviewed changes

Comment thread api/envoy/extensions/clusters/dns/v3/dns_cluster.proto Outdated

API docs clarification

e31a09b

Signed-off-by: Steven Jin Xuan <sjinxuan@microsoft.com>

Stevenjin8 requested a review from markdroth December 18, 2024 19:16

repokitteh-read-only Bot removed the api label Dec 18, 2024

mattklein123 approved these changes Dec 19, 2024

View reviewed changes

mattklein123 merged commit 640fcc0 into envoyproxy:main Dec 19, 2024

keithmattix mentioned this pull request Jan 22, 2025

Drop go-control-plane and rely on subpackages istio/istio#54803

Merged

grnmeira mentioned this pull request Feb 18, 2025

Merging implementations of Strict and Logical DNS #38483

Merged

Conversation

Stevenjin8 commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Sep 26, 2024

Uh oh!

repokitteh-read-only Bot commented Sep 26, 2024

Uh oh!

Stevenjin8 commented Sep 26, 2024

Uh oh!

Uh oh!

Uh oh!

Stevenjin8 commented Oct 2, 2024

Uh oh!

mattklein123 commented Oct 4, 2024

Uh oh!

markdroth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stevenjin8 commented Dec 12, 2024

Uh oh!

Stevenjin8 commented Dec 17, 2024

Uh oh!

markdroth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

markdroth commented Dec 18, 2024

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Stevenjin8 commented Sep 26, 2024 •

edited

Loading