Skip to content

global ratelimit: add integration tests with on_stram_done=true#37762

Closed
mathetake wants to merge 3 commits intoenvoyproxy:mainfrom
mathetake:ratelimitintegrationapplyonstreamdone
Closed

global ratelimit: add integration tests with on_stram_done=true#37762
mathetake wants to merge 3 commits intoenvoyproxy:mainfrom
mathetake:ratelimitintegrationapplyonstreamdone

Conversation

@mathetake
Copy link
Copy Markdown
Member

Commit Message: global ratelimit: add integration tests with on_stram_done=true
Additional Description:

This is a follow up on #37548

Risk Level: none
Testing: done
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

…=true

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37762 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Copy Markdown
Member Author

cc @wbpcode is this enough or do you want me to write anything beyond this?

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
Copy link
Copy Markdown
Member Author

kindly ping @wbpcode

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 22, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant