Skip to content

rls: add unit_multiplier to rls proto#37841

Closed
Pawan-Bishnoi wants to merge 1 commit intoenvoyproxy:mainfrom
Pawan-Bishnoi:rls_unit_multiplier
Closed

rls: add unit_multiplier to rls proto#37841
Pawan-Bishnoi wants to merge 1 commit intoenvoyproxy:mainfrom
Pawan-Bishnoi:rls_unit_multiplier

Conversation

@Pawan-Bishnoi
Copy link
Copy Markdown
Contributor

Commit Message: add a unit multiplier field to rls proto
Additional Description: so that we can configure rate limits for n minutes/days etc.
Risk Level: Low
Testing: todo
Docs Changes: todo
Release Notes: todo
Fixes #33277

Signed-off-by: Pawan Kumar <pawanbishnoi@outlook.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37841 was opened by Pawan-Bishnoi.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #37841 was opened by Pawan-Bishnoi.

see: more, trace.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 29, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2025

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot closed this Feb 5, 2025
@Pawan-Bishnoi
Copy link
Copy Markdown
Contributor Author

/reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiples of units for rate limits

2 participants