http: removing whitespace from appended XFF headers (take 2)#3828
Closed
alyssawilk wants to merge 1 commit into
Closed
http: removing whitespace from appended XFF headers (take 2)#3828alyssawilk wants to merge 1 commit into
alyssawilk wants to merge 1 commit into
Conversation
alyssawilk
force-pushed
the
xff
branch
5 times, most recently
from
4c96dac to
605fa4c
Compare
…nvoyproxy#3587)" (envoyproxy#3609)" This reverts commit 75ca181 with minor docs edits. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
commented
Jul 10, 2018
| * http: better handling of HEAD requests. Now sending transfer-encoding: chunked rather than content-length: 0. | ||
| * http: no longer adding whitespace when appending X-Forwarded-For headers. **Warning**: this is not | ||
| compatible with 1.7.0 builds prior to `9d3a4eb4ac44be9f0651fcc7f87ad98c538b01ee <https://github.com/envoyproxy/envoy/pull/3610>`_. | ||
| See `#3611 <https://github.com/envoyproxy/envoy/issues/3611>`_ for details. |
Contributor
Author
There was a problem hiding this comment.
Hm, on second thought, I wonder if we should wait one more release cycle on this for good form. If everyone else is running from HEAD or close to it, I think we're fine. If anyone is running on release builds, it'll make rolling from 1.7 to 1.8 correctly a bit tricky which arguably it shouldn't be.
Member
There was a problem hiding this comment.
I think I agree (although we run from HEAD), sounds like two release should avoid surprises....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinstating terse XFF appends, now that #3610 has been checked in for a month.
Risk Level: High
Testing: Adapted tests
Docs Changes: n/a
Release Notes: yes
Fixes #3611