Allow Prometheus label values to contain - and .#3830
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jul 10, 2018
Merged
Conversation
… issue envoyproxy#3019 (envoyproxy#3049)" This reverts commit c2751df. Prometheus label values are permitted to contain any Unicode char. The original bug (envoyproxy#3019) was due to metric names not being sanitized, which was resolved by envoyproxy#2303. Change envoyproxy#3049 was therefore unnecessary and leads to an unexpected change in label values. Signed-off-by: Jonathan Oddy <jonathan.oddy@transferwise.com>
JonathanO
force-pushed
the
revert-incorrect-prometheus-label-value-sanitize
branch
from
36a74c1 to
e1e9db1
Compare
htuch
approved these changes
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c2751df (PR #3049)
Description:
The originally reported bug (#3019) was due to metric names not being sanitized, which I think was resolved by #2303.
Change #3049, which was intended to fix #3019, erroneously applied sanitization to label values instead. Prometheus label values are permitted to contain any Unicode char, so this change was unnecessary and leads to an unexpected change in e.g. cluster names.
This PR reverts the change, so that - and . will be preserved in label values.
Risk Level: low