Skip to content

bazel: Use hermetic toolchain for LLVM#39679

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:llvm-toolchains
Dec 2, 2025
Merged

bazel: Use hermetic toolchain for LLVM#39679
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:llvm-toolchains

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented May 30, 2025 •
edited
Loading

Fix #39010

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label May 30, 2025
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented May 30, 2025

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #39679 was opened by phlax.

see: more, trace.

@phlax phlax changed the title bazel: Use hermetic toolchain for llvm [WIP] bazel: Use hermetic toolchain for llvm May 30, 2025
@phlax phlax marked this pull request as draft May 30, 2025 14:08
@phlax phlax force-pushed the llvm-toolchains branch 25 times, most recently from 2a52c1a to c66bfd1 Compare June 2, 2025 21:24
@phlax phlax force-pushed the llvm-toolchains branch 7 times, most recently from 6c20fa7 to 2dd4b34 Compare December 2, 2025 19:46
@phlax phlax changed the title [WIP] bazel: Use hermetic toolchain for LLVM bazel: Use hermetic toolchain for LLVM Dec 2, 2025
@phlax phlax marked this pull request as ready for review December 2, 2025 19:46
@phlax
bazel: Use hermetic toolchain for LLVM
86ae1b6 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Dec 2, 2025

/retest flakey android

mathetake
mathetake reviewed Dec 2, 2025
View reviewed changes
Comment thread contrib/hyperscan/matching/input_matchers/source/BUILD
"NM": "$(NM)",
"OBJCOPY": "$(OBJCOPY)",
"NM": "$$EXT_BUILD_ROOT/$(NM)",
"OBJCOPY": "$$EXT_BUILD_ROOT/$(OBJCOPY)",
Copy link
Copy Markdown
Member

@mathetake mathetake Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙄 why does this guy need nm and objcopy for building a library

Copy link
Copy Markdown
Member Author

@phlax phlax Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question - its a massive resource hog - so quite likely its doing more than we want it to

mathetake
mathetake approved these changes Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally!

@phlax phlax merged commit 0361dee into envoyproxy:main Dec 2, 2025
29 of 30 checks passed
@zirain zirain mentioned this pull request Dec 3, 2025
Closed
@moderation moderation mentioned this pull request Dec 3, 2025
Closed
This was referenced Dec 4, 2025
Closed
Closed
@howardjohn
Copy link
Copy Markdown
Contributor

howardjohn commented Jan 22, 2026

Nice!

fyi https://github.com/envoyproxy/envoy/blob/main/bazel/README.md#linux references a removed file

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jan 22, 2026

yeah - im aware the dev docs are out of date now

currently working on bzlmod - which is going to obsolete/change a lot more - so will go through at that point - would be happy to review prs in the interim

@dosten dosten mentioned this pull request Mar 13, 2026
Closed
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
@phlax @grnmeira
bazel: Use hermetic toolchain for LLVM (envoyproxy#39679)
ff56800 
Fix envoyproxy#39010

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Gustavo <grnmeira@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathetake mathetake mathetake approved these changes

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad is a code owner

@danzh2010 danzh2010 Awaiting requested review from danzh2010 danzh2010 is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@agrawroh agrawroh Awaiting requested review from agrawroh agrawroh is a code owner

Assignees

@jwendell jwendell

@agrawroh agrawroh

Labels

deps Approval required for changes to Envoy's external dependencies no stalebot Disables stalebot from closing an issue workflows:untested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use bazel hermetic toolchain for llvm

5 participants

@phlax @howardjohn @mathetake @jwendell @agrawroh