Skip to content

deps: upgrading GO to v1.24.6 in dependency_imports.bzl#40860

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
adisuissa:go_version_upgrade
Aug 26, 2025
Merged

deps: upgrading GO to v1.24.6 in dependency_imports.bzl#40860
phlax merged 1 commit intoenvoyproxy:mainfrom
adisuissa:go_version_upgrade

Conversation

@adisuissa
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa commented Aug 26, 2025

Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:

compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"

(example)

Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@adisuissa
deps: upgrading GO to v1.24.6 in dependency_imports.bzl
0039ef9 
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Aug 26, 2025

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #40860 was opened by adisuissa.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Aug 26, 2025
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Aug 26, 2025

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #40860 was opened by adisuissa.

see: more, trace.

@melginaldi melginaldi mentioned this pull request Aug 26, 2025
Merged
@adisuissa adisuissa marked this pull request as ready for review August 26, 2025 21:48
phlax
phlax approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @adisuissa

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Aug 26, 2025
@phlax phlax merged commit 2e7cdb1 into envoyproxy:main Aug 26, 2025
24 of 25 checks passed
wtzhang23 pushed a commit to wtzhang23/envoy that referenced this pull request Aug 27, 2025
@adisuissa @wtzhang23
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (envoyproxy#4…
c93ec56 
…0860)

Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))


Signed-off-by: Adi Suissa-Peleg <adip@google.com>
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (envoyproxy#4…
a700aad 
…0860)

Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (#40860)
a0735b4 
Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (envoyproxy#4…
81bd2bd 
…0860)

Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))


Signed-off-by: Adi Suissa-Peleg <adip@google.com>
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (envoyproxy#4…
347d047 
…0860)

Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))


Signed-off-by: Adi Suissa-Peleg <adip@google.com>
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (envoyproxy#4…
baf03f2 
…0860)

Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (envoyproxy#4…
6bcd538 
…0860)

Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (#40860)
af4d494 
Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Sep 2, 2025
@adisuissa @phlax
deps: upgrading GO to v1.24.6 in dependency_imports.bzl (#40860)
7f28969 
Commit Message: deps: upgrading GO to v1.24.6 in dependency_imports.bzl
Additional Description:
Attempt to solve the issue that has been seen today in some PRs:
```
compilepkg: missing strict dependencies:
	/mnt/engflow/worker/work/3/exec/external/org_golang_google_grpc/internal/status/status.go: import of "google.golang.org/genproto/googleapis/rpc/status"
```

([example](https://github.com/envoyproxy/envoy/actions/runs/17246350777/job/48936907349#step:17:601))

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Copilot AI mentioned this pull request Mar 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlax phlax phlax approved these changes

Assignees

@moderation moderation

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adisuissa @phlax @moderation