source_ip_access: add source IP access filter#4091
Closed
d-kowalski wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
source_ip_access: add source IP access filter#4091d-kowalski wants to merge 1 commit intoenvoyproxy:masterfrom
d-kowalski wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: David Kowalski <dkowalski@apple.com>
Member
|
@d-kowalski sorry to throw a wrench in this code which you already wrote, but a quick thought: do we need this filter? Can we use the network level RBAC filter under PR with a policy option to close the connection, etc.? #4083 This is my preference. |
Contributor
Author
|
@mattklein123 no worries. When I looked at RBAC before I saw it's alpha and only had http support, hence this PR. Now it does seem it would cover our use cases and separate filter won't be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
New filter with capability to close connections coming from specified IP addresses. Configuration supporting whitelisting and blacklisting in CIDR notation.
Risk Level: low
Testing: unit/integration tests
Docs Changes: added
Release Notes: added
Signed-off-by: David Kowalski dkowalski@apple.com