tcp_proxy: add upstream_connect_trigger to control connection establishment#41696
Merged
agrawroh merged 31 commits intoenvoyproxy:mainfrom Nov 24, 2025
Merged
tcp_proxy: add upstream_connect_trigger to control connection establishment#41696agrawroh merged 31 commits intoenvoyproxy:mainfrom
agrawroh merged 31 commits intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
agrawroh
force-pushed
the
feat-tls-delay
branch
2 times, most recently
from
0c138e9 to
1a61b45
Compare
…ection establishment Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
feat-tls-delay
branch
from
1a61b45 to
ec1007d
Compare
wbpcode
reviewed
Oct 25, 2025
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
changed the title
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
reviewed
Oct 30, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for the contribution. And some comments are added to the API. (it's much more powerful than I previous review :))
Member
|
/wait |
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
changed the title
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
requested changes
Nov 7, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
thanks for the update. I read the tcp proxy code again and take a deep check to this PR, I think we may need to discuss this again because I misunderstood something before. And sorry about that.
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
reviewed
Nov 17, 2025
wbpcode
reviewed
Nov 17, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for the update. Some more comments are added. :)
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
reviewed
Nov 21, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks so much for the update. And sorry for the delayed new comment. 🌹
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
reviewed
Nov 24, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for the update. My last two comments!!!
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
approved these changes
Nov 24, 2025
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…shment (envoyproxy#41696) ## Description This PR adds a new `upstream_connect_trigger` in TCP Proxy to control how TCP Proxy establishes connections with upstream. In some use-cases we want to delay the connection until we receive the data or let it complete the TLS handshake which is not possible today. --- **Commit Message:** tcp_proxy: add upstream_connect_trigger to control connection establishment **Additional Description:** Adds a new `upstream_connect_trigger` in TCP Proxy to control how TCP Proxy establishes connections with upstream. **Risk Level:** Low **Testing:** Added Unit + Integration Tests **Docs Changes:** Added **Release Notes:** Added --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
upstream_connect_triggerin TCP Proxy to control how TCP Proxy establishes connections with upstream. In some use-cases we want to delay the connection until we receive the data or let it complete the TLS handshake which is not possible today.Commit Message: tcp_proxy: add upstream_connect_trigger to control connection establishment
Additional Description: Adds a new
upstream_connect_triggerin TCP Proxy to control how TCP Proxy establishes connections with upstream.Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added