build: exclude QUIC libraries when HTTP3 is disabled#41886
Merged
jwendell merged 1 commit intoenvoyproxy:mainfrom Nov 7, 2025
Merged
build: exclude QUIC libraries when HTTP3 is disabled#41886jwendell merged 1 commit intoenvoyproxy:mainfrom
jwendell merged 1 commit intoenvoyproxy:mainfrom
Conversation
agrawroh
previously approved these changes
Nov 7, 2025
Member
|
Looks like the CI failures are real. |
Member
Author
|
@agrawroh Indeed, I'm investigating the failures. I should have marked this as draft :/ |
jwendell
force-pushed
the
quiche3
branch
3 times, most recently
from
b6d9290 to
7543a35
Compare
Convert several QUIC libraries in quiche.BUILD to use envoy_quic_cc_library and wrap test dependencies with envoy_select_enable_http3 to ensure they're properly excluded when HTTP3 support is disabled. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Member
Author
|
@agrawroh it's now ready for review! |
jwendell
added a commit
to jwendell/envoy
that referenced
this pull request
Dec 11, 2025
Follows up envoyproxy#41886 Also remove `--build_tests_only` from the CI test so that everything is built and errors like this are caught. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
added a commit
to jwendell/envoy
that referenced
this pull request
Dec 11, 2025
Follows up envoyproxy#41886 Also remove `--build_tests_only` from the CI test so that everything is built and errors like this are caught. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
added a commit
to jwendell/envoy
that referenced
this pull request
Dec 11, 2025
Follows up envoyproxy#41886 Also remove `--build_tests_only` from the CI test so that everything is built and errors like this are caught. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
added a commit
that referenced
this pull request
Dec 11, 2025
Follows up #41886 Also remove `--build_tests_only` from the CI test so that everything is built and errors like this are caught. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
MayorFaj
pushed a commit
to MayorFaj/envoy
that referenced
this pull request
Dec 15, 2025
Follows up envoyproxy#41886 Also remove `--build_tests_only` from the CI test so that everything is built and errors like this are caught. Signed-off-by: Jonh Wendell <jwendell@redhat.com> Signed-off-by: MayorFaj <mayorfaj@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Convert several QUIC libraries in quiche.BUILD to use envoy_quic_cc_library and wrap test dependencies with envoy_select_enable_http3 to ensure they're properly excluded when HTTP3 support is disabled. Signed-off-by: Jonh Wendell <jwendell@redhat.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Follows up envoyproxy#41886 Also remove `--build_tests_only` from the CI test so that everything is built and errors like this are caught. Signed-off-by: Jonh Wendell <jwendell@redhat.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert several QUIC libraries in quiche.BUILD to use envoy_quic_cc_library and wrap test dependencies with envoy_select_enable_http3 to ensure they're properly excluded when HTTP3 support is disabled.