overload_manager: make proactive resource monitors trigger actions#42018
Merged
ggreenway merged 3 commits intoenvoyproxy:mainfrom Nov 22, 2025
Merged
overload_manager: make proactive resource monitors trigger actions#42018ggreenway merged 3 commits intoenvoyproxy:mainfrom
ggreenway merged 3 commits intoenvoyproxy:mainfrom
Conversation
Also, publish a resource pressure gauge like normal resource monitors. Signed-off-by: Greg Greenway <ggreenway@apple.com>
Member
Author
|
/retest |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Member
Author
|
/retest |
KBaichoo
approved these changes
Nov 21, 2025
Contributor
KBaichoo
left a comment
KBaichoo
left a comment
There was a problem hiding this comment.
Looks reasonable to me -- IIRC these were originally designed from managing the allocation of as particular resource e.g. from the tryAllocateResource and deAllocResource e.g. to fail allocing a resource if we hit a limit.
I don't see a reason why we wouldn't want to extend it to also trigger actions based on pressure.
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…nvoyproxy#42018) Also, publish a resource pressure gauge like normal resource monitors. Signed-off-by: Greg Greenway <ggreenway@apple.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, publish a resource pressure gauge like normal resource monitors.
Risk Level: Low
Testing: Added tests
Docs Changes: Docs never indicated that this shouldn't be the behavior, so no doc changes
Release Notes: Added
Platform Specific Features: None