ext_proc: fix a call stats logging issue#42055
Merged
yanavlasov merged 3 commits intoenvoyproxy:mainfrom Nov 21, 2025
Merged
Conversation
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/retest |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
requested review from
mattklein123,
tyxia and
yanavlasov
as code owners
Contributor
Author
|
/assign @yanavlasov @tyxia |
tyxia
reviewed
Nov 18, 2025
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM, module one comment.
Thanks
tyxia
approved these changes
Nov 19, 2025
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM, module one nit (which is up to you) Thanks
Contributor
Author
|
Thanks @tyxia for approval! |
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
In STREAMED or FULL_DUPLEX_STREAMED mode, the body or trailers stats are sometime not logged. This is due to a bug in ext_proc logging implementation which only do the logging when the call_start_time_ is set. However, in STREAMED or FULL_DUPLEX_STREAMED body mode cases, there could be multiple data chunks are sent to the server, and the 1st response will clear the call_start_time_. This causes the rest body responses won't be logged. The solution is to not clear call_start_time_ when a response is received. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In STREAMED or FULL_DUPLEX_STREAMED mode, the body or trailers stats are sometime not logged.
This is due to a bug in ext_proc logging implementation which only do the logging when the call_start_time_ is set. However, in STREAMED or FULL_DUPLEX_STREAMED body mode cases, there could be multiple data chunks are sent to the server, and the 1st response will clear the call_start_time_. This causes the rest body responses won't be logged.
The solution is to not clear call_start_time_ when a response is received.