docs: address some nits on the ExtAuthZ docs#42132
Conversation
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-cncf-pr/42132/docs/index.html The docs are (re-)rendered each time the CI |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up.
Left a few minor suggestions/comments.
| // Existing headers will be appended. | ||
| type.matcher.v3.ListStringMatcher allowed_upstream_headers_to_append = 3; | ||
|
|
||
| // When this :ref:`list <envoy_v3_api_msg_type.matcher.v3.ListStringMatcher>` is set, authorization |
There was a problem hiding this comment.
Just realized that this reference a type, and not the field's name (which IMHO may also not really needed, as the type will have the link).
Not sure if you want to address it as part of this PR (seems like a recurrent pattern in different fields of this file), or just keep as is.
There was a problem hiding this comment.
I'll try to do a follow-up and fix all such instances.
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up!
/lgtm api
## Description Addresses #42132 (comment) --- **Commit Message:** docs: address some nits on the ExtAuthZ docs **Additional Description:** This PR addresses some small nits on the ExtAUthZ docs. **Risk Level:** N/A **Testing:** CI **Docs Changes:** N/A **Release Notes:** N/A Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
## Description Addresses envoyproxy/envoy#42132 (comment) --- **Commit Message:** docs: address some nits on the ExtAuthZ docs **Additional Description:** This PR addresses some small nits on the ExtAUthZ docs. **Risk Level:** N/A **Testing:** CI **Docs Changes:** N/A **Release Notes:** N/A Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Mirrored from https://github.com/envoyproxy/envoy @ 408b1d8604dbd145f4ef3604962b874d5d7fd536
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
## Description Addresses envoyproxy#42132 (comment) --- **Commit Message:** docs: address some nits on the ExtAuthZ docs **Additional Description:** This PR addresses some small nits on the ExtAUthZ docs. **Risk Level:** N/A **Testing:** CI **Docs Changes:** N/A **Release Notes:** N/A Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
3 participants
Description
Addressing some small nits on the ExtAUthZ docs.
Commit Message: docs: address some nits on the ExtAuthZ docs
Additional Description: This PR addresses some small nits on the ExtAUthZ docs.
Risk Level: N/A
Testing: CI
Docs Changes: N/A
Release Notes: N/A