Skip to content

deps: bzlmod migration with BCR dependencies#42190

Closed
mmorel-35 wants to merge 1 commit intoenvoyproxy:mainfrom
mmorel-35:bzlmod-migration
Closed

deps: bzlmod migration with BCR dependencies#42190
mmorel-35 wants to merge 1 commit intoenvoyproxy:mainfrom
mmorel-35:bzlmod-migration

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42190 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Nov 22, 2025
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #42190 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 3 times, most recently from 3cf696c to 2ab02ca Compare November 22, 2025 13:49
@mmorel-35 mmorel-35 changed the title deps: bzlmod migration with BCR dependencies and non-module extension deps: bzlmod migration with BCR dependencies Nov 22, 2025
@mmorel-35 mmorel-35 marked this pull request as ready for review November 22, 2025 14:03
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel Outdated
Comment thread MODULE.bazel
Comment on lines +201 to +209
python.toolchain(
is_default = True,
python_version = "3.12",
)
use_repo(
python,
"python_3_12",
python = "python_versions",
)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Python 3.14 out, can this be bumped to at least 3.13?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python update should be handled separately - 3.13 added a lot of breaking change so ive held off so far

Comment thread MODULE.bazel
Comment on lines +201 to +209
python.toolchain(
is_default = True,
python_version = "3.12",
)
use_repo(
python,
"python_3_12",
python = "python_versions",
)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Python 3.14 out, can this be bumped to at least 3.13?

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 21 times, most recently from f42bfdd to 5728c9c Compare December 15, 2025 18:14
@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 3 times, most recently from f75d377 to 99b1612 Compare December 16, 2025 18:36
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@kyessenov
Copy link
Copy Markdown
Contributor

/waiting
(to silence the nagging bot)

@phlax
Copy link
Copy Markdown
Member

phlax commented Jan 6, 2026

relatedly - im just looking at adding some temporary bzlmod ci - so im looking at this PR - will probably pick some bits out of it

@phlax
Copy link
Copy Markdown
Member

phlax commented Jan 6, 2026

/wait

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants