minor improvement to the document#42196
Merged
phlax merged 2 commits intoenvoyproxy:mainfrom Nov 24, 2025
Merged
Conversation
Signed-off-by: wbpcode <wbphub@gmail.com>
Member
Author
|
See #42189 |
wbpcode
commented
Nov 23, 2025
Comment on lines
+84
to
+85
| timeout: 15s # must be disabled for long-lived and streaming requests | ||
| idle_timeout: 15s # must be disabled for long-lived and streaming requests clusters: |
Member
There was a problem hiding this comment.
Should "clusters:" be in the next line?
Comment on lines
+71
to
+72
| timeout: 15s # must be disabled for long-lived and streaming requests | ||
| idle_timeout: 15s # must be disabled for long-lived and streaming requests |
Member
Author
|
Except the change 1 and change 2, all other changes from the yaml formatter automatically and seems reasonable from me. WDYT? cc @phlax |
phlax
reviewed
Nov 23, 2025
phlax
reviewed
Nov 23, 2025
phlax
reviewed
Nov 23, 2025
Member
|
what yaml formatter? we use yamllint - the config for it is |
Member
Author
Let me also use the yamllint. Then we can avoid unnecesary change. |
Signed-off-by: wbpcode <wbphub@gmail.com>
Contributor
phlax
approved these changes
Nov 24, 2025
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Signed-off-by: wbpcode <wbphub@gmail.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]