Skip to content

bazel: Remove remote-clang/gcc configs and cleanups#42233

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:clang-remote-no
Nov 26, 2025
Merged

bazel: Remove remote-clang/gcc configs and cleanups#42233
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:clang-remote-no

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Nov 24, 2025

toolchain and platform are now separate and we use cc_toolchain_resolution - so --config=clang or --config=gcc should be sufficient (with any platform config separate)

@phlax phlax marked this pull request as draft November 24, 2025 23:34
@phlax phlax changed the title [WIP] bazel/clang: Remove remote-clang config and cleanups [WIP] bazel/clang: Remove remote-clang config and cleanups Nov 24, 2025
@phlax phlax force-pushed the clang-remote-no branch 4 times, most recently from 93e5018 to 3d3d461 Compare November 25, 2025 00:10
@phlax phlax changed the title [WIP] bazel/clang: Remove remote-clang config and cleanups [WIP] bazel: Remove remote-clang/gcc configs and cleanups Nov 25, 2025
@phlax phlax force-pushed the clang-remote-no branch 4 times, most recently from 4abdd3f to 98422e6 Compare November 26, 2025 14:00
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] bazel: Remove remote-clang/gcc configs and cleanups bazel: Remove remote-clang/gcc configs and cleanups Nov 26, 2025
@phlax phlax marked this pull request as ready for review November 26, 2025 16:14
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Nov 26, 2025

/retest infra flake

Copy link
Copy Markdown
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread .bazelrc
build:gcc --host_platform=@envoy//bazel/rbe/toolchains:rbe_linux_gcc_platform

# libc++ default for clang
# libc++ - default for clang
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i felt it needed a bit of clarifying - without the hyphen it reads as a single sentence which has slightly different connotations

@phlax phlax merged commit 800277e into envoyproxy:main Nov 26, 2025
28 checks passed
@zirain zirain mentioned this pull request Nov 28, 2025
phlax added a commit to phlax/envoy that referenced this pull request Nov 28, 2025
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
toolchain and platform are now separate and we use
cc_toolchain_resolution - so `--config=clang` or `--config=gcc` should
be sufficient (with any platform config separate)

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Gustavo <grnmeira@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants