[ProtoApiScrubber] Allow generic matchers to be configured in filter config.#42276
[ProtoApiScrubber] Allow generic matchers to be configured in filter config.#42276adisuissa merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Sumit Kumar <sumitkmr@google.com>
| } | ||
| } | ||
|
|
||
| TEST_F(ProtoApiScrubberFilterConfigTest, MatcherInputTypeValidations) { |
There was a problem hiding this comment.
What will happen now if a non-supported matcher will be used?
Are there tests that cover that? Would adding an integration test for this use-case make sense?
There was a problem hiding this comment.
All the matchers will be supported by this filter after this change and all the inputs would be available for this filter to be used by those matchers. I wasn't able to find any matcher that won't work and hence, to validation is added.
PS: There were some bugs I found after this PR which I'm fixing in a parallel PR (#42293) to fix header and trailer propagation but rest of the inputs flow automatically.
There was a problem hiding this comment.
Sounds strange, and I may be missing something about the how the matcher is used.
|
@sumitkmr2 i think this is awaiting your feedback /wait-any |
|
Yes, actually I'm on leave right now. I'll respond back this Friday.
…On Mon, Dec 8, 2025, 4:22 PM phlax ***@***.***> wrote:
*phlax* left a comment (envoyproxy/envoy#42276)
<#42276 (comment)>
@sumitkmr2 <https://github.com/sumitkmr2> i think this is awaiting your
feedback
/wait-any
—
Reply to this email directly, view it on GitHub
<#42276 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BOJQTFOTG7N5X5VLSFL7HV34AVJ5XAVCNFSM6AAAAACNJCXSOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMRWGMYDAOBZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
/wait-any |
Signed-off-by: Sumit Kumar <sumitkmr@google.com>
| } | ||
| } | ||
|
|
||
| TEST_F(ProtoApiScrubberFilterConfigTest, MatcherInputTypeValidations) { |
There was a problem hiding this comment.
Sounds strange, and I may be missing something about the how the matcher is used.
…config (envoyproxy#42276) Signed-off-by: Sumit Kumar <sumitkmr@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
3 participants
Commit Message: Allow generic matchers to be configured in filter config.
Additional Description: The filter, from inception, supported generic matching. Since it was designed keeping CEL matching in mind, the match input type was restricted to CEL. While writing ITs for other types of matching, it was realized that this is an unnecessary restriction and hence, is being removed. The Integration Tests for other types of matching will be added once Integration Test base PR (#42121) is submitted.
Risk Level: None.
Testing: Negative UTs removed.
Docs Changes: None.
Release Notes: None.
Platform Specific Features: None.
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]