[IMPORTANT] Security patches 25q4#42370
Merged
phlax merged 3 commits intoenvoyproxy:mainfrom Dec 3, 2025
Merged
Conversation
Certificates with an OTHERNAME SAN using type `V_ASN1_UNIVERSALSTRING` or `V_ASN1_BMPSTRING` with an embedded null would have the name truncated at the first null, resulting in an incorrect check. Signed-off-by: Greg Greenway <ggreenway@apple.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
changed the title
botengyao
approved these changes
Dec 3, 2025
Member
|
/retest |
2 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
agrawroh
approved these changes
Dec 3, 2025
Member
|
/retest |
Member
Author
|
we have a couple of issues with ci - pushing this past those |
yanavlasov
pushed a commit
that referenced
this pull request
Dec 12, 2025
With a TODO to fix. We can't roll back the PR that introduced the flakiness (#42370) because it was a security patch. Relevant flakiness described in #39856 (comment) Risk Level: test-only Testing: it is Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com>
MayorFaj
pushed a commit
to MayorFaj/envoy
that referenced
this pull request
Dec 15, 2025
With a TODO to fix. We can't roll back the PR that introduced the flakiness (envoyproxy#42370) because it was a security patch. Relevant flakiness described in envoyproxy#39856 (comment) Risk Level: test-only Testing: it is Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: MayorFaj <mayorfaj@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
With a TODO to fix. We can't roll back the PR that introduced the flakiness (envoyproxy#42370) because it was a security patch. Relevant flakiness described in envoyproxy#39856 (comment) Risk Level: test-only Testing: it is Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 15, 2026
With a TODO to fix. We can't roll back the PR that introduced the flakiness (envoyproxy#42370) because it was a security patch. Relevant flakiness described in envoyproxy#39856 (comment) Risk Level: test-only Testing: it is Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 15, 2026
With a TODO to fix. We can't roll back the PR that introduced the flakiness (envoyproxy#42370) because it was a security patch. Relevant flakiness described in envoyproxy#39856 (comment) Risk Level: test-only Testing: it is Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com>
This was referenced Apr 15, 2026
phlax
pushed a commit
that referenced
this pull request
Apr 15, 2026
With a TODO to fix. We can't roll back the PR that introduced the flakiness (#42370) because it was a security patch. Relevant flakiness described in #39856 (comment) Risk Level: test-only Testing: it is Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com>
phlax
pushed a commit
that referenced
this pull request
Apr 15, 2026
With a TODO to fix. We can't roll back the PR that introduced the flakiness (#42370) because it was a security patch. Relevant flakiness described in #39856 (comment) Risk Level: test-only Testing: it is Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
match_typed_subject_alt_namesmay incorrectly treat certificates containing an embedded null byte