geoip: add support for the MaxMind country db#42419
Merged
agrawroh merged 8 commits intoenvoyproxy:mainfrom Dec 11, 2025
Merged
geoip: add support for the MaxMind country db#42419agrawroh merged 8 commits intoenvoyproxy:mainfrom
agrawroh merged 8 commits intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
Author
|
/retest |
agrawroh
force-pushed
the
feat-geo-cn
branch
7 times, most recently
from
1d2a17b to
5e81e60
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Member
|
/lgtm api |
nezdolik
reviewed
Dec 9, 2025
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
nezdolik
reviewed
Dec 11, 2025
| } | ||
|
|
||
| // Test Country DB lookup when country_db is null and NO City DB. | ||
| TEST_F(GeoipProviderTest, CountryDbLookupWithNullDbAndNoFallback) { |
Member
There was a problem hiding this comment.
nit: I suggest to move all new GeoipProviderTest closer to existing GeoipProviderTest for readability.
Member
|
lgtm modulo one nit |
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
nezdolik
previously approved these changes
Dec 11, 2025
nezdolik
approved these changes
Dec 11, 2025
MayorFaj
pushed a commit
to MayorFaj/envoy
that referenced
this pull request
Dec 15, 2025
## Description This PR adds support for MaxMind Country DB in GeoIP filter. Sometimes corporates purchases the paid version of these datasets and they may not have the city database. --- **Commit Message:** geoip: add support for the MaxMind country db **Additional Description:** Adds support for MaxMind Country DB in GeoIP filter. **Risk Level:** Low **Testing:** Added Unit + Integration Tests **Docs Changes:** Added **Release Notes:** Added --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: MayorFaj <mayorfaj@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
## Description This PR adds support for MaxMind Country DB in GeoIP filter. Sometimes corporates purchases the paid version of these datasets and they may not have the city database. --- **Commit Message:** geoip: add support for the MaxMind country db **Additional Description:** Adds support for MaxMind Country DB in GeoIP filter. **Risk Level:** Low **Testing:** Added Unit + Integration Tests **Docs Changes:** Added **Release Notes:** Added --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for MaxMind Country DB in GeoIP filter. Sometimes corporates purchases the paid version of these datasets and they may not have the city database.
Commit Message: geoip: add support for the MaxMind country db
Additional Description: Adds support for MaxMind Country DB in GeoIP filter.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added