[Cleanup] Move exception-throwing configs out of headers#42436
Merged
ravenblackx merged 3 commits intoenvoyproxy:mainfrom Dec 12, 2025
Merged
[Cleanup] Move exception-throwing configs out of headers#42436ravenblackx merged 3 commits intoenvoyproxy:mainfrom
ravenblackx merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Contributor
Author
|
Assigning wbpcode because this PR was inspired by reviewing #42303 |
Contributor
Author
|
/retest |
wbpcode
approved these changes
Dec 9, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM to the code change. Please check the CI? May merge main to kick it.
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Contributor
Author
|
/retest |
Signed-off-by: Raven Black <ravenblack@dropbox.com>
MayorFaj
pushed a commit
to MayorFaj/envoy
that referenced
this pull request
Dec 15, 2025
…42436) Commit Message: [Cleanup] Move exception-throwing configs out of headers Additional Description: There's a block of validation config in `tools/code_format/config.yaml` which in a comment asserts that there should be no other throws from headers, followed by several headers disobeying that rule. This PR moves two of them that seemed like they fit the "templates" criteria up into to the headers block, removes one that already doesn't contain any throws, and for others moves the functions with throws in them out of the header files into cc files. Risk Level: Negligible, should be no behavior change. Testing: No behavior change. Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: MayorFaj <mayorfaj@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…42436) Commit Message: [Cleanup] Move exception-throwing configs out of headers Additional Description: There's a block of validation config in `tools/code_format/config.yaml` which in a comment asserts that there should be no other throws from headers, followed by several headers disobeying that rule. This PR moves two of them that seemed like they fit the "templates" criteria up into to the headers block, removes one that already doesn't contain any throws, and for others moves the functions with throws in them out of the header files into cc files. Risk Level: Negligible, should be no behavior change. Testing: No behavior change. Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: [Cleanup] Move exception-throwing configs out of headers
Additional Description: There's a block of validation config in
tools/code_format/config.yamlwhich in a comment asserts that there should be no other throws from headers, followed by several headers disobeying that rule. This PR moves two of them that seemed like they fit the "templates" criteria up into to the headers block, removes one that already doesn't contain any throws, and for others moves the functions with throws in them out of the header files into cc files.Risk Level: Negligible, should be no behavior change.
Testing: No behavior change.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a