ext_authz: document the limitations of filter_enabled_metadata#42462
Merged
botengyao merged 5 commits intoenvoyproxy:mainfrom Dec 12, 2025
Merged
ext_authz: document the limitations of filter_enabled_metadata#42462botengyao merged 5 commits intoenvoyproxy:mainfrom
botengyao merged 5 commits intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
agrawroh
force-pushed
the
docs-eauthz-fm
branch
from
4276504 to
89f965e
Compare
adisuissa
previously approved these changes
Dec 8, 2025
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
/lgtm api
It may be better to get someone with more experience with ExtensionWithMatcher to validate the correctness of the filters instantiations.
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
docs-eauthz-fm
branch
from
7a5007e to
22021ce
Compare
agrawroh
force-pushed
the
docs-eauthz-fm
branch
from
b2fc287 to
a03bcf2
Compare
agrawroh
force-pushed
the
docs-eauthz-fm
branch
from
a03bcf2 to
0c61980
Compare
agrawroh
commented
Dec 9, 2025
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Member
Author
|
@adisuissa Could you please take another look at this? |
botengyao
approved these changes
Dec 12, 2025
Member
botengyao
left a comment
botengyao
left a comment
There was a problem hiding this comment.
thanks and lgtm! ExtensionWithMatcher is the recommended way for filter.
MayorFaj
pushed a commit
to MayorFaj/envoy
that referenced
this pull request
Dec 15, 2025
…proxy#42462) ## Description This PR clearly documents the limitations of using `filter_enabled_metadata` in the ExtAuthZ filter and that it doesn't work if the filter itself is disabled in the main filter chain or using a per-route override. We have also provided examples using `ExtensionWithMatcher` which should be the recommended way to invoke filters conditionally. The [previous attempt](envoyproxy#41937) which broke some expectations is reverted. Fix envoyproxy#41501 --- **Commit Message:** ext_authz: document the limitations of filter_enabled_metadata **Additional Description:** Add documentation for describing the limitations around using `filter_enabled_metadata` and provide workaround examples using `ExtensionWithMatcher`. **Risk Level:** N/A **Testing:** CI **Docs Changes:** Added **Release Notes:** N/A --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: MayorFaj <mayorfaj@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…proxy#42462) ## Description This PR clearly documents the limitations of using `filter_enabled_metadata` in the ExtAuthZ filter and that it doesn't work if the filter itself is disabled in the main filter chain or using a per-route override. We have also provided examples using `ExtensionWithMatcher` which should be the recommended way to invoke filters conditionally. The [previous attempt](envoyproxy#41937) which broke some expectations is reverted. Fix envoyproxy#41501 --- **Commit Message:** ext_authz: document the limitations of filter_enabled_metadata **Additional Description:** Add documentation for describing the limitations around using `filter_enabled_metadata` and provide workaround examples using `ExtensionWithMatcher`. **Risk Level:** N/A **Testing:** CI **Docs Changes:** Added **Release Notes:** N/A --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR clearly documents the limitations of using
filter_enabled_metadatain the ExtAuthZ filter and that it doesn't work if the filter itself is disabled in the main filter chain or using a per-route override. We have also provided examples usingExtensionWithMatcherwhich should be the recommended way to invoke filters conditionally.The previous attempt which broke some expectations is reverted.
Fix #41501
Commit Message: ext_authz: document the limitations of filter_enabled_metadata
Additional Description: Add documentation for describing the limitations around using
filter_enabled_metadataand provide workaround examples usingExtensionWithMatcher.Risk Level: N/A
Testing: CI
Docs Changes: Added
Release Notes: N/A