Skip to content

deps/api: Bump envoy_toolshed -> 0.3.10#42570

Merged
phlax merged 1 commit intomainfrom
dependency/bazel-api/envoy_toolshed/0.3.10
Dec 11, 2025
Merged

deps/api: Bump envoy_toolshed -> 0.3.10#42570
phlax merged 1 commit intomainfrom
dependency/bazel-api/envoy_toolshed/0.3.10

Conversation

@dependency-envoy
Copy link
Copy Markdown
Contributor

@dependency-envoy dependency-envoy Bot commented Dec 11, 2025 •
edited by phlax
Loading

Created by Envoy dependency bot for @phlax

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Fix #42562

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Dec 11, 2025
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Dec 11, 2025

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #42570 was opened by dependency-envoy[bot].

see: more, trace.

@phlax phlax force-pushed the dependency/bazel-api/envoy_toolshed/0.3.10 branch from b998c1b to 21c9d37 Compare December 11, 2025 15:11
@phlax phlax enabled auto-merge (squash) December 11, 2025 15:12
phlax
phlax previously approved these changes Dec 11, 2025
View reviewed changes
@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 11, 2025
@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 11, 2025

/retest ios transient

@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 11, 2025

/retest transients

@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 11, 2025

seems like github problem

/retest

@moderation
Copy link
Copy Markdown
Contributor

moderation commented Dec 11, 2025

I see we have the dependency duplicated in two locations. Is there a way to consolidate?

@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 11, 2025

i would prefer there werent - its related to bzlmod

cc @mmorel-35

@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 11, 2025

i think the reason is that if the api is published as a bzlmod (ie separately) it would need to specify its dependency on toolshed and not rely on envoy providing it

@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 11, 2025

this needs the recently added uadk lib to switch to using hermetic libnuma cc @MisaKokoro @jwendell

@phlax phlax mentioned this pull request Dec 11, 2025
Merged
@phlax phlax force-pushed the dependency/bazel-api/envoy_toolshed/0.3.10 branch from 21c9d37 to 1d9381c Compare December 11, 2025 15:41
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Dec 11, 2025
@moderation
Copy link
Copy Markdown
Contributor

moderation commented Dec 11, 2025

/lgtm deps

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 11, 2025
phlax added a commit that referenced this pull request Dec 11, 2025
@phlax
contrib/kae: Use hermetic libnuma (#42571)
b747e22 
Unblock #42570

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the dependency/bazel-api/envoy_toolshed/0.3.10 branch from 1d9381c to 7b34ffc Compare December 11, 2025 16:09
@dependency-envoy @phlax
deps/api: Bump envoy_toolshed -> 0.3.10
486bda1 
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
@phlax phlax force-pushed the dependency/bazel-api/envoy_toolshed/0.3.10 branch from 7b34ffc to 486bda1 Compare December 11, 2025 16:10
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Dec 11, 2025
@mmorel-35
Copy link
Copy Markdown
Contributor

mmorel-35 commented Dec 11, 2025

i would prefer there werent - its related to bzlmod

Until envoy has migrated to bzlmod it will stay like that because toolshed is used by envoy and envoy_api modules.
We first need a published version in BCR for envoy_toolshed

@phlax phlax merged commit 71839c3 into main Dec 11, 2025
25 of 28 checks passed
MayorFaj pushed a commit to MayorFaj/envoy that referenced this pull request Dec 15, 2025
@phlax @MayorFaj
contrib/kae: Use hermetic libnuma (envoyproxy#42571)
3d5bee3 
Unblock envoyproxy#42570

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: MayorFaj <mayorfaj@gmail.com>
MayorFaj pushed a commit to MayorFaj/envoy that referenced this pull request Dec 15, 2025
@dependency-envoy @MayorFaj
deps/api: Bump envoy_toolshed -> 0.3.10 (envoyproxy#42570)
781469c 
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: MayorFaj <mayorfaj@gmail.com>
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
@phlax @grnmeira
contrib/kae: Use hermetic libnuma (envoyproxy#42571)
c5f1e40 
Unblock envoyproxy#42570

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Gustavo <grnmeira@gmail.com>
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
@dependency-envoy @grnmeira
deps/api: Bump envoy_toolshed -> 0.3.10 (envoyproxy#42570)
a0f29e8 
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
Signed-off-by: Gustavo <grnmeira@gmail.com>
@phlax phlax deleted the dependency/bazel-api/envoy_toolshed/0.3.10 branch May 8, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwendell jwendell jwendell approved these changes

@phlax phlax phlax left review comments

Assignees

@moderation moderation

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Still get error "include/liburing/compat.h:25:10: fatal error: 'linux/openat2.h' file not found" when building liburing

4 participants

@phlax @moderation @mmorel-35 @jwendell