Don't access variable used as move construction src#42574
Merged
kyessenov merged 1 commit intoenvoyproxy:mainfrom Dec 11, 2025
Merged
Don't access variable used as move construction src#42574kyessenov merged 1 commit intoenvoyproxy:mainfrom
kyessenov merged 1 commit intoenvoyproxy:mainfrom
Conversation
Avoid a potential use-after-free or logic error caused by access of a variable that was already used as the argument to a move constructor. Signed-off-by: Alex Bakon <abakon@netflix.com>
Contributor
Author
|
This was found by inspection but in theory could have been detected by an existing clang-tidy check. |
Member
|
cc @jwendell who is looking at bringing back clang-tidy |
MayorFaj
pushed a commit
to MayorFaj/envoy
that referenced
this pull request
Dec 15, 2025
…proxy#42574) Commit Message: Don't access variable used as move construction src Additional Description: Avoid a potential use-after-free or logic error caused by access of a variable that was already used as the argument to a move constructor. Risk Level: low Testing: ran existing unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com> Signed-off-by: MayorFaj <mayorfaj@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…proxy#42574) Commit Message: Don't access variable used as move construction src Additional Description: Avoid a potential use-after-free or logic error caused by access of a variable that was already used as the argument to a move constructor. Risk Level: low Testing: ran existing unit tests Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Alex Bakon <abakon@netflix.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Don't access variable used as move construction src
Additional Description:
Avoid a potential use-after-free or logic error caused by access of a variable that was already used as the argument to a move constructor.
Risk Level: low
Testing: ran existing unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a