router: fix a bug where the buffer limit has incorrect precedence#42611
Merged
yanavlasov merged 3 commits intoenvoyproxy:mainfrom Dec 16, 2025
Merged
router: fix a bug where the buffer limit has incorrect precedence#42611yanavlasov merged 3 commits intoenvoyproxy:mainfrom
yanavlasov merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Member
Author
|
This also need to be back ported to 1.36 |
Member
Author
|
/retest |
agrawroh
approved these changes
Dec 15, 2025
Member
Author
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @phlax |
Member
Author
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @yanavlasov |
yanavlasov
approved these changes
Dec 16, 2025
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…voyproxy#42611) We introduced a bug at envoyproxy#40254 where the legacy vhost buffer limit will take precedence over the legacy route buffer limit. Risk Level: low. Testing: unit. Docs Changes: n/a. Release Notes: added. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: router: fix a bug where the buffer limit has incorrect precedence
Additional Description:
We introduced a bug at #40254 where the legacy vhost buffer limit will take precedence over the legacy route buffer limit.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.