lrs: proper shutdown of the LRS stream#43083
Merged
adisuissa merged 3 commits intoenvoyproxy:mainfrom Jan 30, 2026
Merged
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
mattklein123
previously approved these changes
Jan 24, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
mattklein123
approved these changes
Jan 30, 2026
shane-yuan
pushed a commit
to shane-yuan/envoy
that referenced
this pull request
Feb 11, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 24, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 24, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 24, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
This was referenced Apr 27, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot AI
pushed a commit
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Apr 28, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Apr 29, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Apr 29, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Apr 29, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Apr 30, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Apr 30, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Co-authored-by: phlax <454682+phlax@users.noreply.github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: lrs: proper shutdown of the LRS stream
Additional Description:
Adds a proper destruction of the load-reporter object, and closes the gRPC stream to ensure that it is cleaned prior to the load-reporter.
Should also address the flakiness reported in #41532.
Risk Level: low - bug fix
Testing: Updated unit tests.
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A