formatter: add access log formatters for tracking upstream hosts and connection IDs attempted#43215
Merged
Merged
Conversation
…connection IDs attempted Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
IssaAbuKalbein
requested review from
danzh2010 and
mattklein123
as code owners
Contributor
Author
|
/retest |
Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
Contributor
Author
|
/retest |
yanavlasov
reviewed
Feb 10, 2026
| * This is useful for tracking retry behavior in access logs. | ||
| * @param host the host description that was attempted. | ||
| */ | ||
| virtual void addUpstreamHostAttempted(Upstream::HostDescriptionConstSharedPtr host) PURE; |
Contributor
There was a problem hiding this comment.
I think we can add this behavior to the existing setUpstreamHost and setUpstreamConnectionId since they are always called together now. Let me know what you think.
Contributor
Author
There was a problem hiding this comment.
I've merged addUpstreamConnectionIdAttempted into setUpstreamConnectionId — all 4 call sites were always paired together, so setUpstreamConnectionId now automatically pushes to the attempted list and the separate addUpstreamConnectionIdAttempted API has been removed.
For setUpstreamHost / addUpstreamHostAttempted however, these can't be safely merged. setUpstreamHost has 12 call sites but only 3 are paired with addUpstreamHostAttempted. The other 9 include health checkers, ext_proc, ext_authz, pool success/failure callbacks, and low-level connection creation — these set the host for informational purposes but don't represent routing attempts. Merging would pollute UPSTREAM_HOST_NAMES_ATTEMPTED with non-routing entries (e.g., health check hosts).
…e usage Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
IssaAbuKalbein
temporarily deployed
to
external-contributors
GitHub Actions
Inactive
Contributor
Author
|
/retest |
Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
yanavlasov
approved these changes
Mar 1, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…connection IDs attempted (envoyproxy#43215) Adds new access log formatters to track all upstream hosts and connection IDs attempted during request processing: - `%UPSTREAM_HOSTS_ATTEMPTED%` - Comma-separated list of upstream host addresses (ip:port) - `%UPSTREAM_HOSTS_ATTEMPTED_WITHOUT_PORT%` - Upstream host addresses without port - `%UPSTREAM_HOST_NAMES_ATTEMPTED%` - Upstream host names - `%UPSTREAM_HOST_NAMES_ATTEMPTED_WITHOUT_PORT%` - Upstream host names without port - `%UPSTREAM_CONNECTION_IDS_ATTEMPTED%` - Connection IDs used during request processing Extended `StreamInfo::UpstreamInfo` interface with methods to track attempted hosts and connection IDs. Implemented tracking in HTTP router, TCP proxy, and UDP proxy. __Risk Level:__ Low __Testing:__ Unit tests added for all new formatters. Mocks updated for new interface methods. __Docs Changes:__ Updated `docs/root/configuration/advanced/substitution_formatter.rst` with documentation for all new formatters. __Release Notes:__ Added entry in `changelogs/current.yaml`. __Platform Specific Features:__ N/A --------- Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com> Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com> Co-authored-by: Issa Abu Kalbein <iabukalbein@microsoft.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…connection IDs attempted (envoyproxy#43215) Adds new access log formatters to track all upstream hosts and connection IDs attempted during request processing: - `%UPSTREAM_HOSTS_ATTEMPTED%` - Comma-separated list of upstream host addresses (ip:port) - `%UPSTREAM_HOSTS_ATTEMPTED_WITHOUT_PORT%` - Upstream host addresses without port - `%UPSTREAM_HOST_NAMES_ATTEMPTED%` - Upstream host names - `%UPSTREAM_HOST_NAMES_ATTEMPTED_WITHOUT_PORT%` - Upstream host names without port - `%UPSTREAM_CONNECTION_IDS_ATTEMPTED%` - Connection IDs used during request processing Extended `StreamInfo::UpstreamInfo` interface with methods to track attempted hosts and connection IDs. Implemented tracking in HTTP router, TCP proxy, and UDP proxy. __Risk Level:__ Low __Testing:__ Unit tests added for all new formatters. Mocks updated for new interface methods. __Docs Changes:__ Updated `docs/root/configuration/advanced/substitution_formatter.rst` with documentation for all new formatters. __Release Notes:__ Added entry in `changelogs/current.yaml`. __Platform Specific Features:__ N/A --------- Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com> Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com> Co-authored-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…connection IDs attempted (envoyproxy#43215) Adds new access log formatters to track all upstream hosts and connection IDs attempted during request processing: - `%UPSTREAM_HOSTS_ATTEMPTED%` - Comma-separated list of upstream host addresses (ip:port) - `%UPSTREAM_HOSTS_ATTEMPTED_WITHOUT_PORT%` - Upstream host addresses without port - `%UPSTREAM_HOST_NAMES_ATTEMPTED%` - Upstream host names - `%UPSTREAM_HOST_NAMES_ATTEMPTED_WITHOUT_PORT%` - Upstream host names without port - `%UPSTREAM_CONNECTION_IDS_ATTEMPTED%` - Connection IDs used during request processing Extended `StreamInfo::UpstreamInfo` interface with methods to track attempted hosts and connection IDs. Implemented tracking in HTTP router, TCP proxy, and UDP proxy. __Risk Level:__ Low __Testing:__ Unit tests added for all new formatters. Mocks updated for new interface methods. __Docs Changes:__ Updated `docs/root/configuration/advanced/substitution_formatter.rst` with documentation for all new formatters. __Release Notes:__ Added entry in `changelogs/current.yaml`. __Platform Specific Features:__ N/A --------- Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com> Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com> Co-authored-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…connection IDs attempted (envoyproxy#43215) Adds new access log formatters to track all upstream hosts and connection IDs attempted during request processing: - `%UPSTREAM_HOSTS_ATTEMPTED%` - Comma-separated list of upstream host addresses (ip:port) - `%UPSTREAM_HOSTS_ATTEMPTED_WITHOUT_PORT%` - Upstream host addresses without port - `%UPSTREAM_HOST_NAMES_ATTEMPTED%` - Upstream host names - `%UPSTREAM_HOST_NAMES_ATTEMPTED_WITHOUT_PORT%` - Upstream host names without port - `%UPSTREAM_CONNECTION_IDS_ATTEMPTED%` - Connection IDs used during request processing Extended `StreamInfo::UpstreamInfo` interface with methods to track attempted hosts and connection IDs. Implemented tracking in HTTP router, TCP proxy, and UDP proxy. __Risk Level:__ Low __Testing:__ Unit tests added for all new formatters. Mocks updated for new interface methods. __Docs Changes:__ Updated `docs/root/configuration/advanced/substitution_formatter.rst` with documentation for all new formatters. __Release Notes:__ Added entry in `changelogs/current.yaml`. __Platform Specific Features:__ N/A --------- Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com> Signed-off-by: Issa Abu Kalbein <86603440+IssaAbuKalbein@users.noreply.github.com> Co-authored-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: formatter: add access log formatters for tracking upstream hosts and connection IDs attempted
Additional Description: Adds new access log formatters to track all upstream hosts and connection IDs attempted during request processing:
%UPSTREAM_HOSTS_ATTEMPTED%- Comma-separated list of upstream host addresses (ip:port)%UPSTREAM_HOSTS_ATTEMPTED_WITHOUT_PORT%- Upstream host addresses without port%UPSTREAM_HOST_NAMES_ATTEMPTED%- Upstream host names%UPSTREAM_HOST_NAMES_ATTEMPTED_WITHOUT_PORT%- Upstream host names without port%UPSTREAM_CONNECTION_IDS_ATTEMPTED%- Connection IDs used during request processingExtended
StreamInfo::UpstreamInfointerface with methods to track attempted hosts and connection IDs. Implemented tracking in HTTP router, TCP proxy, and UDP proxy.Risk Level: Low
Testing: Unit tests added for all new formatters. Mocks updated for new interface methods.
Docs Changes: Updated
docs/root/configuration/advanced/substitution_formatter.rstwith documentation for all new formatters.Release Notes: Added entry in
changelogs/current.yaml.Platform Specific Features: N/A