deps: More renaming for bzlmod alignment#43265
Merged
Merged
Conversation
phlax
requested review from
KBaichoo,
RyanTheOptimist,
abeyad,
danzh2010,
ggreenway,
kyessenov,
mattklein123,
nezdolik,
tonya11en,
wbpcode,
yanavlasov and
zuercher
as code owners
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
force-pushed
the
deps-rename
branch
10 times, most recently
from
c3fb118 to
a90b419
Compare
phlax
changed the title
phlax
commented
Feb 3, 2026
phlax
force-pushed
the
deps-rename
branch
3 times, most recently
from
77d4725 to
fcbf817
Compare
Member
Author
|
/retest mobile |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
adisuissa
approved these changes
Feb 4, 2026
This was referenced Feb 7, 2026
Merged
shane-yuan
pushed a commit
to shane-yuan/envoy
that referenced
this pull request
Feb 11, 2026
while renaming is not strictly required for bzlmod on the basis that we can name things in the way we like internally with bzlmod - best practice is to use the published names for our migration - many of these deps will have a different name anyway - and so it will make the migration a lot smoother if this is done in advance - and make actual changes easier to see/review some have already been renamed - eg xds, which was done separately as it was a large change fwiw ive tried doing this previously (exmperimentally) with a few of our deps but at that time i wasnt clear of the end goal - now that is in reach and kinda waiting on a few preparation steps The main change was updating the names of the locations in: bazel/repository_locations.bzl. This required updating all the starlark files *e.g., BUILD files) that pointed to these locations. --------- Signed-off-by: Ryan Northey <ryan@synca.io>
nickshokri
pushed a commit
to nickshokri/envoy
that referenced
this pull request
Mar 17, 2026
while renaming is not strictly required for bzlmod on the basis that we can name things in the way we like internally with bzlmod - best practice is to use the published names for our migration - many of these deps will have a different name anyway - and so it will make the migration a lot smoother if this is done in advance - and make actual changes easier to see/review some have already been renamed - eg xds, which was done separately as it was a large change fwiw ive tried doing this previously (exmperimentally) with a few of our deps but at that time i wasnt clear of the end goal - now that is in reach and kinda waiting on a few preparation steps The main change was updating the names of the locations in: bazel/repository_locations.bzl. This required updating all the starlark files *e.g., BUILD files) that pointed to these locations. --------- Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: nick <nickshokri@google.com>
nickshokri
pushed a commit
to nickshokri/envoy
that referenced
this pull request
Mar 17, 2026
while renaming is not strictly required for bzlmod on the basis that we can name things in the way we like internally with bzlmod - best practice is to use the published names for our migration - many of these deps will have a different name anyway - and so it will make the migration a lot smoother if this is done in advance - and make actual changes easier to see/review some have already been renamed - eg xds, which was done separately as it was a large change fwiw ive tried doing this previously (exmperimentally) with a few of our deps but at that time i wasnt clear of the end goal - now that is in reach and kinda waiting on a few preparation steps The main change was updating the names of the locations in: bazel/repository_locations.bzl. This required updating all the starlark files *e.g., BUILD files) that pointed to these locations. --------- Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: nick <nickshokri@google.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
while renaming is not strictly required for bzlmod on the basis that we can name things in the way we like internally with bzlmod - best practice is to use the published names for our migration - many of these deps will have a different name anyway - and so it will make the migration a lot smoother if this is done in advance - and make actual changes easier to see/review some have already been renamed - eg xds, which was done separately as it was a large change fwiw ive tried doing this previously (exmperimentally) with a few of our deps but at that time i wasnt clear of the end goal - now that is in reach and kinda waiting on a few preparation steps The main change was updating the names of the locations in: bazel/repository_locations.bzl. This required updating all the starlark files *e.g., BUILD files) that pointed to these locations. --------- Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while renaming is not strictly required for bzlmod on the basis that we can name things in the way we like internally with bzlmod - best practice is to use the published names
for our migration - many of these deps will have a different name anyway - and so it will make the migration a lot smoother if this is done in advance - and make actual changes easier to see/review
some have already been renamed - eg xds, which was done separately as it was a large change
fwiw ive tried doing this previously (exmperimentally) with a few of our deps but at that time i wasnt clear of the end goal - now that is in reach and kinda waiting on a few preparation steps
The main change was updating the names of the locations in: bazel/repository_locations.bzl.
This required updating all the starlark files *e.g., BUILD files) that pointed to these locations.