Filter out unknown fields in ProtoApiScrubber by nickshokri · Pull Request #43315 · envoyproxy/envoy

nickshokri · 2026-02-03T20:42:17Z

Commit Message: Add an unknown field filter in the ProtoApiScrubber's CheckField() method. A max depth cap of 100 was also added to prevent stack overflow.
Additional Description: Note that AI was used for creating the unit tests
Risk Level: Low
Testing: Added unit tests and confirmed they pass
Docs Changes: Added to ProtoApiScrubber documentation the existence of an unknown field filter
Release Notes: Added section under "minor changes"
Platform Specific Features: N/A

repokitteh-read-only · 2026-02-03T20:42:23Z

Hi @nickshokri, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #43315 was opened by nickshokri.

see: more, trace.

repokitteh-read-only · 2026-02-05T21:28:42Z

@sumitkmr2 cannot be assigned to this issue.

🐱

Caused by: a #43315 (comment) was created by @adisuissa.

see: more, trace.

repokitteh-read-only · 2026-02-05T21:50:38Z

nickshokri is not allowed to assign users.

🐱

Caused by: a #43315 (comment) was created by @nickshokri.

see: more, trace.

yanavlasov · 2026-02-12T16:25:22Z

@nickshokri please merge main

@sumitkmr2 please also review the change

/wait

phlax

a couple of docs nits

RyanTheOptimist · 2026-02-27T22:37:29Z

@phlax friendly ping

repokitteh-read-only · 2026-03-04T23:28:34Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #43315 was synchronize by nickshokri.

see: more, trace.

agrawroh · 2026-03-12T05:44:18Z

cc @adisuissa Gentle ping on this for a review.

adisuissa

Thanks!
Overall LGTM.
/lgtm api
Please consider adding an integration test that will show what are the expected inputs and outputs in the case of scrubbing.

nickshokri · 2026-03-16T21:59:53Z

@adisuissa friendly ping on this. I'm hoping to get this in by EOW.

adisuissa

LGTM, thanks!

adisuissa · 2026-03-17T13:03:37Z

Please fix DCO

Signed-off-by: nick <nickshokri@google.com>

…to unknown_field_filter Signed-off-by: nick <nickshokri@google.com>

Signed-off-by: nick <nickshokri@google.com>

…voyproxy#43315) Signed-off-by: nick <nickshokri@google.com> Signed-off-by: Kuat <kyessenov@users.noreply.github.com> Co-authored-by: Kuat <kyessenov@users.noreply.github.com>

…voyproxy#43315) Signed-off-by: nick <nickshokri@google.com> Signed-off-by: Kuat <kyessenov@users.noreply.github.com> Co-authored-by: Kuat <kyessenov@users.noreply.github.com> Signed-off-by: Xuyang Tao <taoxuy@google.com>

…voyproxy#43315) Signed-off-by: nick <nickshokri@google.com> Signed-off-by: Kuat <kyessenov@users.noreply.github.com> Co-authored-by: Kuat <kyessenov@users.noreply.github.com> Signed-off-by: Jonathan Wu <jtwu@google.com>

…voyproxy#43315) Signed-off-by: nick <nickshokri@google.com> Signed-off-by: Kuat <kyessenov@users.noreply.github.com> Co-authored-by: Kuat <kyessenov@users.noreply.github.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>

…voyproxy#43315) Signed-off-by: nick <nickshokri@google.com> Signed-off-by: Kuat <kyessenov@users.noreply.github.com> Co-authored-by: Kuat <kyessenov@users.noreply.github.com>

nickshokri requested a review from adisuissa as a code owner February 3, 2026 20:42

KBaichoo assigned adisuissa Feb 4, 2026

adisuissa reviewed Feb 5, 2026

View reviewed changes

Comment thread docs/root/configuration/http/http_filters/proto_api_scrubber_filter.rst Outdated

nickshokri requested a review from adisuissa February 5, 2026 21:51

repokitteh-read-only Bot added the waiting label Feb 12, 2026

phlax reviewed Feb 13, 2026

View reviewed changes

Comment thread docs/root/configuration/http/http_filters/proto_api_scrubber_filter.rst Outdated

Comment thread docs/root/configuration/http/http_filters/proto_api_scrubber_filter.rst

repokitteh-read-only Bot removed the waiting label Feb 18, 2026

nickshokri had a problem deploying to external-contributors February 18, 2026 21:22 — with GitHub Actions Error

nickshokri temporarily deployed to external-contributors March 4, 2026 23:28 — with GitHub Actions Inactive

repokitteh-read-only Bot added the api label Mar 4, 2026

sumitkmr2 approved these changes Mar 5, 2026

View reviewed changes

Comment thread changelogs/current.yaml Outdated

Comment thread docs/root/configuration/http/http_filters/proto_api_scrubber_filter.rst Outdated

nickshokri had a problem deploying to external-contributors March 5, 2026 22:07 — with GitHub Actions Error

nickshokri had a problem deploying to external-contributors March 5, 2026 22:15 — with GitHub Actions Error

nickshokri had a problem deploying to external-contributors March 5, 2026 22:17 — with GitHub Actions Error

nickshokri had a problem deploying to external-contributors March 5, 2026 22:20 — with GitHub Actions Error

nickshokri requested a review from phlax March 5, 2026 22:21

adisuissa reviewed Mar 13, 2026

View reviewed changes

Comment thread changelogs/current.yaml Outdated

repokitteh-read-only Bot removed the api label Mar 13, 2026

nickshokri had a problem deploying to external-contributors March 14, 2026 00:17 — with GitHub Actions Error

nickshokri requested a review from adisuissa March 14, 2026 00:17

adisuissa previously approved these changes Mar 17, 2026

View reviewed changes

nickshokri added 6 commits March 19, 2026 22:28

Removing unused code

56388b1

Signed-off-by: nick <nickshokri@google.com>

Updating docs

f3bec3c

Signed-off-by: nick <nickshokri@google.com>

Fix formatting of docs

21a081d

Signed-off-by: nick <nickshokri@google.com>

fix doc formatting

a4c5951

Signed-off-by: nick <nickshokri@google.com>

updating docs

b9ecd5c

Signed-off-by: nick <nickshokri@google.com>

Merge branch 'unknown_field_filter' of github.com:nickshokri/envoy in…

d482d78

…to unknown_field_filter Signed-off-by: nick <nickshokri@google.com>

nickshokri had a problem deploying to external-contributors March 24, 2026 18:17 — with GitHub Actions Error

fix formatting issue

2b59ece

Signed-off-by: nick <nickshokri@google.com>

auto-merge was automatically disabled March 24, 2026 18:47
Head branch was pushed to by a user without write access

nickshokri dismissed adisuissa’s stale review via 2b59ece March 24, 2026 18:47

nickshokri had a problem deploying to external-contributors March 24, 2026 18:47 — with GitHub Actions Error

nickshokri requested a review from adisuissa March 24, 2026 18:48

fix yaml formatting

ddc7de4

Signed-off-by: nick <nickshokri@google.com>

nickshokri temporarily deployed to external-contributors March 24, 2026 19:25 — with GitHub Actions Inactive

adisuissa previously approved these changes Mar 24, 2026

View reviewed changes

adisuissa enabled auto-merge (squash) March 24, 2026 19:35

fixing broken ref in yaml

5d39c87

Signed-off-by: nick <nickshokri@google.com>

auto-merge was automatically disabled March 24, 2026 20:06
Head branch was pushed to by a user without write access

nickshokri dismissed adisuissa’s stale review via 5d39c87 March 24, 2026 20:06

nickshokri had a problem deploying to external-contributors March 24, 2026 20:07 — with GitHub Actions Error

nickshokri temporarily deployed to external-contributors March 24, 2026 20:07 — with GitHub Actions Inactive

adisuissa approved these changes Mar 25, 2026

View reviewed changes

adisuissa enabled auto-merge (squash) March 25, 2026 13:11

adisuissa merged commit 80754fe into envoyproxy:main Mar 25, 2026
31 of 33 checks passed

phlax mentioned this pull request Apr 22, 2026

changelogs: Pre-release cleanups #44581

Merged

Conversation

nickshokri commented Feb 3, 2026

Uh oh!

repokitteh-read-only Bot commented Feb 3, 2026

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Feb 5, 2026

Uh oh!

repokitteh-read-only Bot commented Feb 5, 2026

Uh oh!

yanavlasov commented Feb 12, 2026

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RyanTheOptimist commented Feb 27, 2026

Uh oh!

repokitteh-read-only Bot commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

agrawroh commented Mar 12, 2026

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nickshokri commented Mar 16, 2026

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

adisuissa commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants