golang callaback: add DownstreamSslConnection by fl0Lec · Pull Request #43480 · envoyproxy/envoy

fl0Lec · 2026-02-13T15:33:51Z

adding downstreamSslConnection to have 1:1 matching with Lua features

Commit Message: adding downstreamSslConnection to have 1:1 matching with Lua features
Additional Description:
Risk Level: Low
Testing: Integration test
Docs Changes: No
Release Notes: Yes
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

repokitteh-read-only · 2026-02-13T15:33:57Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #43480 was opened by fl0Lec.

see: more, trace.

doujiang24

@fl0Lec , Nice work!

wdauchy

nice work on the feature parity with Lua, the Go interface and tests look solid. I have a few concerns mostly around the C API surface area and some consistency nits.

wdauchy · 2026-02-17T08:32:13Z

 }

+func (n *connectionCallback) DownstreamSslConnection() api.SslConnection {
+	panic("implement me")


the interface contract says "returns nil if the connection is not secured with SSL/TLS". panic("implement me") will crash at runtime instead. consider returning nil here to match the documented behavior, same as the other unimplemented stubs that return zero values.

Returning nil here would actually be misleading, since per the interface contract nil specifically means "the connection is not secured with SSL/TLS". That would be incorrect - the connection might be secured, we just haven't implemented this functionality for network filters yet.

The panic("implement me") pattern is consistent with other unimplemented methods in this file (e.g., GetRouteName, FilterChainName, Protocol, ResponseCode, DynamicMetadata, UpstreamClusterName, etc.). The network filter is less commonly used than the HTTP filter, so these stubs exist to fulfill the Go interface while signaling that the functionality isn't available yet.

If/when we implement SSL connection support for network filters, we'll replace the panic with the actual implementation.
Which could be done in a followup PR if needed

wdauchy

looks good to me. the refactoring to use EnvoyValue enum dispatch with getStringValue/getIntegerValue/getStringsValue is much cleaner than the original 21 separate C API functions. the null byte separator for SANs and the streamInfo() revert are also addressed. nice work.

fl0Lec · 2026-02-19T14:08:40Z

cc: @doujiang24 if you could re-review the PR

doujiang24

Sorry for the late, just back from a long vocation.

adding downstreamSslConnection to have 1:1 matching with Lua features Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

adding additional GetStringsValue Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

clone string to avoid dept Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

keeping the String `\0` separated Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

unify test header Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

fl0Lec · 2026-02-26T09:13:38Z

the CI failure is unrelated to this PR and is failing on other PR

doujiang24 · 2026-02-26T14:19:35Z

/retest

doujiang24

Nice work, LGTM

…face

fl0Lec · 2026-02-27T08:13:23Z

@botengyao could we also get a review with write access ?

fl0Lec · 2026-02-27T12:49:26Z

/retest

doujiang24 · 2026-02-28T02:58:28Z

Cool, all tests passed, it's good to merge. cc @wbpcode @phlax Thanks!

adding downstreamSslConnection to have 1:1 matching with Lua features Commit Message: adding downstreamSslConnection to have 1:1 matching with Lua features Additional Description: Risk Level: Low Testing: Integration test Docs Changes: No Release Notes: Yes Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>

adding downstreamSslConnection to have 1:1 matching with Lua features Commit Message: adding downstreamSslConnection to have 1:1 matching with Lua features Additional Description: Risk Level: Low Testing: Integration test Docs Changes: No Release Notes: Yes Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

fl0Lec force-pushed the fl/golang-ssl-interface branch 2 times, most recently from d9c8ed6 to 14987e0 Compare February 16, 2026 11:11

fl0Lec marked this pull request as ready for review February 16, 2026 15:35

fl0Lec force-pushed the fl/golang-ssl-interface branch from 14987e0 to 1346b00 Compare February 16, 2026 15:43

fl0Lec marked this pull request as draft February 16, 2026 15:43

fl0Lec force-pushed the fl/golang-ssl-interface branch from 1346b00 to be7e9ce Compare February 16, 2026 15:44

fl0Lec marked this pull request as ready for review February 16, 2026 16:33

doujiang24 reviewed Feb 17, 2026

View reviewed changes

Comment thread contrib/golang/common/go/api/api.h Outdated

wdauchy reviewed Feb 17, 2026

View reviewed changes

fl0Lec force-pushed the fl/golang-ssl-interface branch from c75025e to 5baf742 Compare February 17, 2026 10:30

fl0Lec requested review from doujiang24 and wdauchy February 17, 2026 11:38

fl0Lec force-pushed the fl/golang-ssl-interface branch from 4628e67 to dd97604 Compare February 17, 2026 19:11

wdauchy approved these changes Feb 17, 2026

View reviewed changes

botengyao assigned doujiang24 Feb 18, 2026

doujiang24 reviewed Feb 24, 2026

View reviewed changes

Comment thread contrib/golang/common/go/api/filter.go Outdated

Comment thread contrib/golang/filters/http/source/go/pkg/http/capi_impl.go Outdated

Comment thread contrib/golang/filters/http/source/go/pkg/http/capi_impl.go Outdated

doujiang24 reviewed Feb 25, 2026

View reviewed changes

Comment thread contrib/golang/filters/http/source/go/pkg/http/capi_impl.go Outdated

fl0Lec requested a review from doujiang24 February 25, 2026 14:43

fl0Lec added 7 commits February 26, 2026 08:55

golang callaback: add DownstreamSslConnection

f3b2968

adding downstreamSslConnection to have 1:1 matching with Lua features Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

adding entry to current.yaml

85655b3

Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

using GetIntegerValue and GetStringValue

3e10aea

adding additional GetStringsValue Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

comment + revert streamInfo to private

9b715f8

Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

remove bool present when clear

13519c9

clone string to avoid dept Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

using getStringValue instead of getStringsValue

27a9833

keeping the String `\0` separated Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

factorize go code and add useful comment

fbb0cd7

unify test header Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>

fl0Lec force-pushed the fl/golang-ssl-interface branch from 6e50073 to fbb0cd7 Compare February 26, 2026 08:55

doujiang24 approved these changes Feb 27, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into fl/golang-ssl-inter…

366b376

…face

wbpcode approved these changes Feb 28, 2026

View reviewed changes

wbpcode merged commit 573db97 into envoyproxy:main Feb 28, 2026
28 checks passed

Conversation

fl0Lec commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Feb 13, 2026

Uh oh!

doujiang24 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wdauchy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wdauchy Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

fl0Lec Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

wdauchy left a comment

Choose a reason for hiding this comment

Uh oh!

fl0Lec commented Feb 19, 2026

Uh oh!

doujiang24 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fl0Lec commented Feb 26, 2026

Uh oh!

doujiang24 commented Feb 26, 2026

Uh oh!

doujiang24 left a comment

Choose a reason for hiding this comment

Uh oh!

fl0Lec commented Feb 27, 2026

Uh oh!

fl0Lec commented Feb 27, 2026

Uh oh!

doujiang24 commented Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fl0Lec commented Feb 13, 2026 •

edited

Loading