tls: Const-correct some more uses of X509 API#43568
Merged
Merged
Conversation
This future-proofs Envoy and is needed to keep it building with later versions of BoringSSL. BoringSSL plans to const-correct these APIs and making ASN1_STRING opaque, in order to unblock some memory usage improvements in X509. See also http://github.com/envoyproxy/envoy/pull/41022 for more details. This PR has no behavior change. It is purely to fix some const issues in Envoy. Signed-off-by: David Benjamin <davidben@google.com>
davidben
requested review from
botengyao,
mathetake and
tyxia
as code owners
RyanTheOptimist
approved these changes
Feb 24, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
Commit Message: This future-proofs Envoy and is needed to keep it building with later versions of BoringSSL. BoringSSL plans to const-correct these APIs and making ASN1_STRING opaque, in order to unblock some memory usage improvements in X509. See also http://github.com/envoyproxy/envoy/pull/41022 for more details. This PR has no behavior change. It is purely to fix some const issues in Envoy. Additional Description: Risk Level: none Testing: CI checks it compiles Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: David Benjamin <davidben@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
Commit Message: This future-proofs Envoy and is needed to keep it building with later versions of BoringSSL. BoringSSL plans to const-correct these APIs and making ASN1_STRING opaque, in order to unblock some memory usage improvements in X509. See also http://github.com/envoyproxy/envoy/pull/41022 for more details. This PR has no behavior change. It is purely to fix some const issues in Envoy. Additional Description: Risk Level: none Testing: CI checks it compiles Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: David Benjamin <davidben@google.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
Commit Message: This future-proofs Envoy and is needed to keep it building with later versions of BoringSSL. BoringSSL plans to const-correct these APIs and making ASN1_STRING opaque, in order to unblock some memory usage improvements in X509. See also http://github.com/envoyproxy/envoy/pull/41022 for more details. This PR has no behavior change. It is purely to fix some const issues in Envoy. Additional Description: Risk Level: none Testing: CI checks it compiles Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: David Benjamin <davidben@google.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
Commit Message: This future-proofs Envoy and is needed to keep it building with later versions of BoringSSL. BoringSSL plans to const-correct these APIs and making ASN1_STRING opaque, in order to unblock some memory usage improvements in X509. See also http://github.com/envoyproxy/envoy/pull/41022 for more details. This PR has no behavior change. It is purely to fix some const issues in Envoy. Additional Description: Risk Level: none Testing: CI checks it compiles Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: David Benjamin <davidben@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This future-proofs Envoy and is needed to keep it building with later versions of BoringSSL. BoringSSL plans to const-correct these APIs and making ASN1_STRING opaque, in order to unblock some memory usage improvements in X509.
See also http://github.com/envoyproxy/envoy/pull/41022 for more details.
This PR has no behavior change. It is purely to fix some const issues in Envoy.
Additional Description:
Risk Level: none
Testing: CI checks it compiles
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a