Skip to content

mcp: Support session negotiation in McpJsonRestBridge HTTP filter.#43575

Merged
botengyao merged 14 commits into
envoyproxy:mainfrom
guoyilin42:mcp-bridge
Feb 27, 2026
Merged

mcp: Support session negotiation in McpJsonRestBridge HTTP filter.#43575
botengyao merged 14 commits into
envoyproxy:mainfrom
guoyilin42:mcp-bridge

Conversation

@guoyilin42
Copy link
Copy Markdown
Contributor

@guoyilin42 guoyilin42 commented Feb 21, 2026

Commit Message: mcp: Support session negotiation in McpJsonRestBridge HTTP filter.
Additional Description: Handle initialized, notification initialize
Risk Level: Medium
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

API submitted in #43400

Signed-off-by: Yilin Guo <guoyilin@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

Hi @guoyilin42, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #43575 was opened by guoyilin42.

see: more, trace.

@guoyilin42 guoyilin42 changed the title feat: Implement and integrate the McpJsonRestBridge HTTP filter. mcp: Support session negotiation in McpJsonRestBridge HTTP filter. Feb 21, 2026
@guoyilin42
Copy link
Copy Markdown
Contributor Author

@paulhong01

Comment thread source/extensions/filters/http/mcp_json_rest_bridge/mcp_json_rest_bridge_filter.h Outdated
Comment thread source/extensions/filters/http/mcp_json_rest_bridge/mcp_json_rest_bridge_filter.h Outdated
Copy link
Copy Markdown
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking it off! Left several comments to start.

/wait

Comment thread source/extensions/filters/http/mcp_json_rest_bridge/config.h
@botengyao botengyao self-assigned this Feb 22, 2026
Copy link
Copy Markdown
Contributor

@wdauchy wdauchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is a solid starting point for the bridge filter. paulhong01 and botengyao already covered good ground, so I'll focus on a couple of things not yet mentioned.

Comment thread source/extensions/filters/http/mcp_json_rest_bridge/mcp_json_rest_bridge_filter.h Outdated
Comment thread source/extensions/filters/http/mcp_json_rest_bridge/mcp_json_rest_bridge_filter.h Outdated
Comment thread source/extensions/filters/http/mcp_json_rest_bridge/config.cc
@tyxia tyxia self-assigned this Feb 23, 2026
Signed-off-by: Yilin Guo <guoyilin@google.com>
Copy link
Copy Markdown
Member

@tyxia tyxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Good start, I am fleshing out some comments.

Comment thread source/extensions/filters/http/mcp_json_rest_bridge/config.cc Outdated
@tyxia
Copy link
Copy Markdown
Member

tyxia commented Feb 24, 2026

/wait

Signed-off-by: Yilin Guo <guoyilin@google.com>
Signed-off-by: Yilin Guo <guoyilin@google.com>
Signed-off-by: Yilin Guo <guoyilin@google.com>
Signed-off-by: Yilin Guo <guoyilin@google.com>
Signed-off-by: Yilin Guo <guoyilin@google.com>
@guoyilin42
Copy link
Copy Markdown
Contributor Author

Could you add a change log please? It is at changelog.yaml
/wait

I don't feel Change log is needed as it is incomplete implementation, i.e., this filter can not be even installed in the filter chain due the buffer issue i mentioned above

I don't feel strong and It doesn't hurt to add one though

Added a change log. PTAL. Thanks!

botengyao
botengyao previously approved these changes Feb 27, 2026
@botengyao botengyao enabled auto-merge (squash) February 27, 2026 13:28
tyxia
tyxia previously approved these changes Feb 27, 2026
Copy link
Copy Markdown
Member

@tyxia tyxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

Signed-off-by: Yilin Guo <guoyilin@google.com>
auto-merge was automatically disabled February 27, 2026 18:43

Head branch was pushed to by a user without write access

@guoyilin42 guoyilin42 dismissed stale reviews from tyxia and botengyao via 9987b9a February 27, 2026 18:43
@guoyilin42 guoyilin42 temporarily deployed to external-contributors February 27, 2026 18:43 — with GitHub Actions Inactive
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/coverage.yaml).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #43575 was synchronize by guoyilin42.

see: more, trace.

tyxia
tyxia previously approved these changes Feb 27, 2026
@tyxia tyxia enabled auto-merge (squash) February 27, 2026 18:57
Signed-off-by: Yilin Guo <guoyilin@google.com>
auto-merge was automatically disabled February 27, 2026 20:10

Head branch was pushed to by a user without write access

@guoyilin42 guoyilin42 temporarily deployed to external-contributors February 27, 2026 20:10 — with GitHub Actions Inactive
@botengyao botengyao enabled auto-merge (squash) February 27, 2026 20:12
@botengyao botengyao merged commit 6c3e1eb into envoyproxy:main Feb 27, 2026
30 of 32 checks passed
@guoyilin42 guoyilin42 deleted the mcp-bridge branch February 28, 2026 01:03
bmjask pushed a commit to bmjask/envoy that referenced this pull request Mar 14, 2026
…nvoyproxy#43575)

<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)

!!!ATTENTION!!!

Please check the [use of generative AI
policy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md?plain=1#L41).

You may use generative AI only if you fully understand the code. You
need to disclose
this usage in the PR description to ensure transparency.
-->

Commit Message: mcp: Support session negotiation in McpJsonRestBridge
HTTP filter.
Additional Description: Handle initialized, notification initialize
Risk Level: Medium
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

API submitted in envoyproxy#43400

---------

Signed-off-by: Yilin Guo <guoyilin@google.com>
Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle pushed a commit to bvandewalle/envoy that referenced this pull request Mar 17, 2026
…nvoyproxy#43575)

<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)

!!!ATTENTION!!!

Please check the [use of generative AI
policy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md?plain=1#L41).

You may use generative AI only if you fully understand the code. You
need to disclose
this usage in the PR description to ensure transparency.
-->

Commit Message: mcp: Support session negotiation in McpJsonRestBridge
HTTP filter.
Additional Description: Handle initialized, notification initialize
Risk Level: Medium
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

API submitted in envoyproxy#43400

---------

Signed-off-by: Yilin Guo <guoyilin@google.com>
fishcakez pushed a commit to fishcakez/envoy that referenced this pull request Mar 25, 2026
…nvoyproxy#43575)

<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)

!!!ATTENTION!!!

Please check the [use of generative AI
policy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md?plain=1#L41).

You may use generative AI only if you fully understand the code. You
need to disclose
this usage in the PR description to ensure transparency.
-->

Commit Message: mcp: Support session negotiation in McpJsonRestBridge
HTTP filter.
Additional Description: Handle initialized, notification initialize
Risk Level: Medium
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

API submitted in envoyproxy#43400

---------

Signed-off-by: Yilin Guo <guoyilin@google.com>
krinkinmu pushed a commit to grnmeira/envoy that referenced this pull request Apr 20, 2026
…nvoyproxy#43575)

<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)

!!!ATTENTION!!!

Please check the [use of generative AI
policy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md?plain=1#L41).

You may use generative AI only if you fully understand the code. You
need to disclose
this usage in the PR description to ensure transparency.
-->

Commit Message: mcp: Support session negotiation in McpJsonRestBridge
HTTP filter.
Additional Description: Handle initialized, notification initialize
Risk Level: Medium
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

API submitted in envoyproxy#43400

---------

Signed-off-by: Yilin Guo <guoyilin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants