mobile: re-add Python APIs by danzh2010 · Pull Request #43605 · envoyproxy/envoy

danzh2010 · 2026-02-23T19:52:47Z

Re-adds Python bindings targeting the current C++ API surface (EngineBuilder, Engine, StreamClient, StreamPrototype, Stream) using pybind11. Includes GIL-safe callback shims, Python dict/bytes type conversions, a fetch client example, and an integration test.

Patched from #43514
Co-Authored-By: Claude noreply@anthropic.com
Co-Authored-By: Gemini CLI

Risk Level: low, no change to existing APIs and features
Testing: new tests added
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

…envoyproxy#43514) Signed-off-by: Dan Zhang <danzh@google.com>

Signed-off-by: Dan Zhang <danzh@google.com>

repokitteh-read-only · 2026-02-23T19:52:52Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #43605 was opened by danzh2010.

see: more, trace.

Signed-off-by: Dan Zhang <danzh@google.com>

repokitteh-read-only · 2026-02-23T21:40:15Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #43605 was ready_for_review by danzh2010.

see: more, trace.

danzh2010 · 2026-02-23T21:49:30Z

/assign @abeyad

Signed-off-by: Dan Zhang <danzh@google.com>

abeyad · 2026-02-24T16:54:32Z

Thanks @danzh2010 ! Question: do we know if any existing CI workflow actually executes the Python tests? If not, should we add it here?

Signed-off-by: Dan Zhang <danzh@google.com>

danzh2010 · 2026-02-27T16:36:15Z

please review the black dep changes. /assign @phlax

danzh2010 · 2026-02-27T16:36:28Z

/assign @phlax

phlax

some python feedback ...

phlax · 2026-02-27T16:44:55Z

+                        setattr(destination, attr, val)
+                    except Exception as e:
+                        print(f"Error copying attribute {attr}: {e}")
+            except Exception as e:


most linters wont allow this - you need to be more specific about what type of error

wouldn't we want a catch-all for try block?

generally you dont want to catch a bare exception - just named ones

the reason being - on unexpected failure the program should fail - so if you catch something the more specific the better ... also because you might catch things you had not expected to

Signed-off-by: Dan Zhang <danzh@google.com>

abeyad · 2026-02-28T05:10:15Z

/retest

abeyad

thanks @danzh2010 !

abeyad · 2026-03-02T18:21:07Z

+  return self.setOnEngineExit([shared_closure]() {
+    py::gil_scoped_acquire acquire;
+    (*shared_closure)();
+  });


FWIW, I don't know enough Python myself to know if this is the proper use of the GIL scope etc, but I'm just trusting the AI got it right :)

Signed-off-by: Dan Zhang <danzh@google.com>

phlax

python looks loads better, thanks @danzh2010

(not sure about the pybind stuff - didnt review it as dont have much experience with it)

danzh2010 · 2026-03-02T19:28:10Z

/retest

abeyad · 2026-03-03T15:26:27Z

/retest

abeyad

LGTM, thanks @danzh2010 !

Signed-off-by: Dan Zhang <danzh@google.com>

tested wf breakout from envoyproxy#43605 renames wfs for consistency (android tests etc are soon going to be ~merged into Mobile/Android eg) Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>

Re-adds Python bindings targeting the current C++ API surface (EngineBuilder, Engine, StreamClient, StreamPrototype, Stream) using pybind11. Includes GIL-safe callback shims, Python dict/bytes type conversions, a fetch client example, and an integration test. Patched from envoyproxy#43514 Co-Authored-By: Claude [noreply@anthropic.com](mailto:noreply@anthropic.com) Co-Authored-By: Gemini CLI Risk Level: low, no change to existing APIs and features Testing: new tests added Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>

tested wf breakout from envoyproxy#43605 renames wfs for consistency (android tests etc are soon going to be ~merged into Mobile/Android eg) Signed-off-by: Ryan Northey <ryan@synca.io>

Re-adds Python bindings targeting the current C++ API surface (EngineBuilder, Engine, StreamClient, StreamPrototype, Stream) using pybind11. Includes GIL-safe callback shims, Python dict/bytes type conversions, a fetch client example, and an integration test. Patched from envoyproxy#43514 Co-Authored-By: Claude [noreply@anthropic.com](mailto:noreply@anthropic.com) Co-Authored-By: Gemini CLI Risk Level: low, no change to existing APIs and features Testing: new tests added Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com>

tested wf breakout from envoyproxy#43605 renames wfs for consistency (android tests etc are soon going to be ~merged into Mobile/Android eg) Signed-off-by: Ryan Northey <ryan@synca.io>

Re-adds Python bindings targeting the current C++ API surface (EngineBuilder, Engine, StreamClient, StreamPrototype, Stream) using pybind11. Includes GIL-safe callback shims, Python dict/bytes type conversions, a fetch client example, and an integration test. Patched from envoyproxy#43514 Co-Authored-By: Claude [noreply@anthropic.com](mailto:noreply@anthropic.com) Co-Authored-By: Gemini CLI Risk Level: low, no change to existing APIs and features Testing: new tests added Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com>

tested wf breakout from envoyproxy#43605 renames wfs for consistency (android tests etc are soon going to be ~merged into Mobile/Android eg) Signed-off-by: Ryan Northey <ryan@synca.io>

Re-adds Python bindings targeting the current C++ API surface (EngineBuilder, Engine, StreamClient, StreamPrototype, Stream) using pybind11. Includes GIL-safe callback shims, Python dict/bytes type conversions, a fetch client example, and an integration test. Patched from envoyproxy#43514 Co-Authored-By: Claude [noreply@anthropic.com](mailto:noreply@anthropic.com) Co-Authored-By: Gemini CLI Risk Level: low, no change to existing APIs and features Testing: new tests added Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com>

danzh1989 added 3 commits February 20, 2026 20:02

mobile: add Python API bindings for Envoy Mobile via pybind11 (from PR …

3b467f8

…envoyproxy#43514) Signed-off-by: Dan Zhang <danzh@google.com>

fix dependbot

15387e7

Signed-off-by: Dan Zhang <danzh@google.com>

revert precommit config

132c1c7

Signed-off-by: Dan Zhang <danzh@google.com>

repokitteh-read-only Bot added the workflows:untested label Feb 23, 2026

danzh2010 changed the title ~~Pythonapi~~ mobile: re-add Python APIs Feb 23, 2026

fix bazel build

ef9c2ff

Signed-off-by: Dan Zhang <danzh@google.com>

danzh2010 marked this pull request as ready for review February 23, 2026 21:40

danzh2010 requested review from RyanTheOptimist, abeyad, agrawroh, jwendell and phlax as code owners February 23, 2026 21:40

repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Feb 23, 2026

repokitteh-read-only Bot assigned moderation Feb 23, 2026

repokitteh-read-only Bot assigned abeyad Feb 23, 2026

make test more meantingful

14de185

Signed-off-by: Dan Zhang <danzh@google.com>

danzh1989 added 10 commits February 24, 2026 19:33

format

1b3d01d

Signed-off-by: Dan Zhang <danzh@google.com>

format script

41a7fdd

Signed-off-by: Dan Zhang <danzh@google.com>

run python test

0093e5b

Signed-off-by: Dan Zhang <danzh@google.com>

fix ci

52ae728

Signed-off-by: Dan Zhang <danzh@google.com>

install black

8a7f6ad

Signed-off-by: Dan Zhang <danzh@google.com>

fix format

fbc1ae4

Signed-off-by: Dan Zhang <danzh@google.com>

try to run python test

7a49e9f

Signed-off-by: Dan Zhang <danzh@google.com>

Merge branch 'main' into pythonapi

cbf41c7

Signed-off-by: Dan Zhang <danzh@google.com>

another try to fix format CI

5d2faa5

Signed-off-by: Dan Zhang <danzh@google.com>

properly include black in formatting

d1737c3

Signed-off-by: Dan Zhang <danzh@google.com>

repokitteh-read-only Bot assigned phlax Feb 27, 2026

phlax removed workflows:untested labels Feb 27, 2026

phlax reviewed Feb 27, 2026

View reviewed changes

enable trace logging

eecb33f

Signed-off-by: Dan Zhang <danzh@google.com>

repokitteh-read-only Bot added the workflows:untested label Feb 27, 2026

danzh1989 added 2 commits February 27, 2026 20:24

move test suites one per test file

e38fef2

Signed-off-by: Dan Zhang <danzh@google.com>

add test server

0e7e016

Signed-off-by: Dan Zhang <danzh@google.com>

abeyad reviewed Mar 2, 2026

View reviewed changes

address python review

fcca152

Signed-off-by: Dan Zhang <danzh@google.com>

phlax approved these changes Mar 2, 2026

View reviewed changes

repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 2, 2026

abeyad approved these changes Mar 3, 2026

View reviewed changes

Merge branch 'main' into pythonapi

6d69f1d

Signed-off-by: Dan Zhang <danzh@google.com>

danzh2010 enabled auto-merge (squash) March 3, 2026 16:34

danzh2010 merged commit 863c24e into envoyproxy:main Mar 3, 2026
29 checks passed

Copilot AI mentioned this pull request Apr 2, 2026

mobile: isolate black formatter into mobile-specific pip_parse, update to 26.3.1 #44240

Closed

Conversation

danzh2010 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Feb 23, 2026

Uh oh!

repokitteh-read-only Bot commented Feb 23, 2026

Uh oh!

danzh2010 commented Feb 23, 2026

Uh oh!

abeyad commented Feb 24, 2026

Uh oh!

danzh2010 commented Feb 27, 2026

Uh oh!

danzh2010 commented Feb 27, 2026

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phlax Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

danzh2010 Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

phlax Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

phlax Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

danzh2010 Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

abeyad commented Feb 28, 2026

Uh oh!

abeyad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abeyad Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

danzh2010 commented Mar 2, 2026

Uh oh!

abeyad commented Mar 3, 2026

Uh oh!

abeyad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

danzh2010 commented Feb 23, 2026 •

edited

Loading