dynamic_modules: add generic accessors for access logger#43647
Merged
Conversation
agrawroh
force-pushed
the
feat-hal-2
branch
2 times, most recently
from
dc37798 to
13883db
Compare
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
mathetake
previously approved these changes
Feb 26, 2026
Member
mathetake
left a comment
mathetake
left a comment
There was a problem hiding this comment.
Thank you! This is much clearer and more consistent
mathetake
previously approved these changes
Feb 26, 2026
wbpcode
requested changes
Feb 26, 2026
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for this great contribution.
I think this is a break change to ABI because the previous AIB have been released in 1.37? Could we keep previous code (ABI and ABI implementation) but mark them as deprecated and remove them after the it's out of supported?
Member
|
ping me we we get agreement about the break change here is acceptable here. |
Member
|
yeah let's do the deprecation stuff |
Member
Author
|
Yeah, I will depreciate them instead of removing. Good callout! |
Contributor
|
@agrawroh ping on deprecation rather than removal |
Contributor
|
/wait |
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
mathetake
reviewed
Mar 24, 2026
| * @param logger_envoy_ptr is the pointer to the log context. | ||
| * @return true if this is a health check, false otherwise. | ||
| */ | ||
| bool envoy_dynamic_module_callback_access_logger_is_health_check( |
Member
Author
There was a problem hiding this comment.
Yeah, we are not deprecating it and it's already part of Access Logger. I just need to remove it from here.
mathetake
reviewed
Mar 24, 2026
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
approved these changes
Mar 25, 2026
Comment on lines
-6420
to
+6448
| bool envoy_dynamic_module_callback_access_logger_get_upstream_tls_version( | ||
| bool envoy_dynamic_module_callback_access_logger_get_upstream_tls_cipher( |
Member
There was a problem hiding this comment.
Could we ensure this ABI is not released in 1.37?
TAOXUY
pushed a commit
to TAOXUY/envoy
that referenced
this pull request
Apr 1, 2026
…43647) ## Description --- **Commit Message:** dynamic_modules: add generic accessors for access logger **Additional Description:** **Risk Level:** Low **Testing:** CI **Docs Changes:** Added **Release Notes:** N/A --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Xuyang Tao <taoxuy@google.com>
citrus7
pushed a commit
to citrus7/envoy
that referenced
this pull request
Apr 1, 2026
…43647) ## Description --- **Commit Message:** dynamic_modules: add generic accessors for access logger **Additional Description:** **Risk Level:** Low **Testing:** CI **Docs Changes:** Added **Release Notes:** N/A --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Jonathan Wu <jtwu@google.com>
nshipilov
pushed a commit
to nshipilov/envoy
that referenced
this pull request
Apr 13, 2026
…43647) ## Description --- **Commit Message:** dynamic_modules: add generic accessors for access logger **Additional Description:** **Risk Level:** Low **Testing:** CI **Docs Changes:** Added **Release Notes:** N/A --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…43647) ## Description --- **Commit Message:** dynamic_modules: add generic accessors for access logger **Additional Description:** **Risk Level:** Low **Testing:** CI **Docs Changes:** Added **Release Notes:** N/A --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit Message: dynamic_modules: add generic accessors for access logger
Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: N/A