sds: reduce copy of a structure by returning a const-ref#43648
Merged
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
botengyao
approved these changes
Feb 27, 2026
Member
botengyao
left a comment
botengyao
left a comment
There was a problem hiding this comment.
lgtm, thanks for the improvement!
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…43648) Commit Message: sds: reduce copy of a structure by returning a const-ref Additional Description: Internal refactor to return a const-ref instead of a copy in the `secretData()` method. Risk Level: low - internal change Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…43648) Commit Message: sds: reduce copy of a structure by returning a const-ref Additional Description: Internal refactor to return a const-ref instead of a copy in the `secretData()` method. Risk Level: low - internal change Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…43648) Commit Message: sds: reduce copy of a structure by returning a const-ref Additional Description: Internal refactor to return a const-ref instead of a copy in the `secretData()` method. Risk Level: low - internal change Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…43648) Commit Message: sds: reduce copy of a structure by returning a const-ref Additional Description: Internal refactor to return a const-ref instead of a copy in the `secretData()` method. Risk Level: low - internal change Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: sds: reduce copy of a structure by returning a const-ref
Additional Description:
Internal refactor to return a const-ref instead of a copy in the
secretData()method.Risk Level: low - internal change
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A