dym sdk: add on destory event hook#43673
Merged
Merged
Conversation
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
requested review from
agrawroh,
mathetake and
mattklein123
as code owners
… dev-add-on-destory-to-filter
wbpcode
changed the title
mathetake
reviewed
Feb 27, 2026
| * after onStreamComplete and access logs are flushed. This is a good place to release | ||
| * any per-stream resources. | ||
| */ | ||
| virtual void onDestroy() = 0; |
Member
There was a problem hiding this comment.
I'm sure this is not necessary to be idiomatic Rust for Rust SDK where we can use Drop trait already but isn't it the same for C++ here? This is essentially the same as Deconstructor ?
Member
Author
There was a problem hiding this comment.
This is designed initially for golang where users doesn't want to use the finalizer, and then I think keep cpp and golang be same make no side effect anyway, esp they are almost same in all other positions. So, I also added it for cpp. I have no strong point if you want to remove it.
Member
There was a problem hiding this comment.
yeah not strong as long as Rust doesn't have it
mathetake
approved these changes
Feb 27, 2026
Contributor
|
This PR seems to be breaking CI (https://github.com/envoyproxy/envoy/actions/runs/22502826468/job/65194038428#step:19:498). I'm not sure how it passed CI in the first place. Should this be reverted? |
Member
Merged
mathetake
added a commit
that referenced
this pull request
Feb 27, 2026
Follow up on #43673 Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
Commit Message: dym skd: add on destory event hook Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
Follow up on envoyproxy#43673 Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
Commit Message: dym skd: add on destory event hook Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
Follow up on envoyproxy#43673 Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
Commit Message: dym skd: add on destory event hook Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
Follow up on envoyproxy#43673 Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
Commit Message: dym skd: add on destory event hook Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
Follow up on envoyproxy#43673 Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dym skd: add on destory event hook
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]