test: use a common test setup function in ext_authz_http_impl_test#43691
Merged
Conversation
Signed-off-by: Eugene Chan <eugenechan@google.com>
pianiststickman
changed the title
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…st (envoyproxy#43691) Commit Message: use a common test setup function in ext_authz_http_impl_test.cc Additional Description: `std::make_shared()` is often marked `[[nodiscard]]`, so using it as a statement without checking its value may lead to compilation warnings. `createConfig()` is already present and conveniently does the right things, so we may as well use it. Risk Level: none Testing: ran the test being modified Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Eugene Chan <eugenechan@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…st (envoyproxy#43691) Commit Message: use a common test setup function in ext_authz_http_impl_test.cc Additional Description: `std::make_shared()` is often marked `[[nodiscard]]`, so using it as a statement without checking its value may lead to compilation warnings. `createConfig()` is already present and conveniently does the right things, so we may as well use it. Risk Level: none Testing: ran the test being modified Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Eugene Chan <eugenechan@google.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…st (envoyproxy#43691) Commit Message: use a common test setup function in ext_authz_http_impl_test.cc Additional Description: `std::make_shared()` is often marked `[[nodiscard]]`, so using it as a statement without checking its value may lead to compilation warnings. `createConfig()` is already present and conveniently does the right things, so we may as well use it. Risk Level: none Testing: ran the test being modified Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Eugene Chan <eugenechan@google.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…st (envoyproxy#43691) Commit Message: use a common test setup function in ext_authz_http_impl_test.cc Additional Description: `std::make_shared()` is often marked `[[nodiscard]]`, so using it as a statement without checking its value may lead to compilation warnings. `createConfig()` is already present and conveniently does the right things, so we may as well use it. Risk Level: none Testing: ran the test being modified Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Eugene Chan <eugenechan@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: use a common test setup function in ext_authz_http_impl_test.cc
Additional Description:
std::make_shared()is often marked[[nodiscard]], so using it as a statement without checking its value may lead to compilation warnings.createConfig()is already present and conveniently does the right things, so we may as well use it.Risk Level: none
Testing: ran the test being modified
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a