dym: improve the stream callout to handle the reset on initialization#43701
Merged
Merged
Conversation
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
requested review from
agrawroh,
mathetake and
mattklein123
as code owners
mathetake
approved these changes
Mar 1, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…envoyproxy#43701) Commit Message: dym: improve the stream callout to handle the reset on initialization Additional Description: In the previous implementation, the reset on initialization will be propagate to module by event hook and the status of `startHttpStream` will be `Success`. In the new implementation, all failures on initialization will not trigger the event hook but will result in error status of `startHttpStream`. The failure on initialization is very tricky and hard to process in practice of Envoy extension. It's hard to change current implementation of Envoy because it's used everywhere, but we still have chance to make the better usability for dynamic module. Risk Level: low. Testing: unit. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…envoyproxy#43701) Commit Message: dym: improve the stream callout to handle the reset on initialization Additional Description: In the previous implementation, the reset on initialization will be propagate to module by event hook and the status of `startHttpStream` will be `Success`. In the new implementation, all failures on initialization will not trigger the event hook but will result in error status of `startHttpStream`. The failure on initialization is very tricky and hard to process in practice of Envoy extension. It's hard to change current implementation of Envoy because it's used everywhere, but we still have chance to make the better usability for dynamic module. Risk Level: low. Testing: unit. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…envoyproxy#43701) Commit Message: dym: improve the stream callout to handle the reset on initialization Additional Description: In the previous implementation, the reset on initialization will be propagate to module by event hook and the status of `startHttpStream` will be `Success`. In the new implementation, all failures on initialization will not trigger the event hook but will result in error status of `startHttpStream`. The failure on initialization is very tricky and hard to process in practice of Envoy extension. It's hard to change current implementation of Envoy because it's used everywhere, but we still have chance to make the better usability for dynamic module. Risk Level: low. Testing: unit. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…envoyproxy#43701) Commit Message: dym: improve the stream callout to handle the reset on initialization Additional Description: In the previous implementation, the reset on initialization will be propagate to module by event hook and the status of `startHttpStream` will be `Success`. In the new implementation, all failures on initialization will not trigger the event hook but will result in error status of `startHttpStream`. The failure on initialization is very tricky and hard to process in practice of Envoy extension. It's hard to change current implementation of Envoy because it's used everywhere, but we still have chance to make the better usability for dynamic module. Risk Level: low. Testing: unit. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dym: improve the stream callout to handle the reset on initialization
Additional Description:
In the previous implementation, the reset on initialization will be propagate to module by event hook and the status of
startHttpStreamwill beSuccess.In the new implementation, all failures on initialization will not trigger the event hook but will result in error status of
startHttpStream.The failure on initialization is very tricky and hard to process in practice of Envoy extension. It's hard to change current implementation of Envoy because it's used everywhere, but we still have chance to make the better usability for dynamic module.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.