Skip to content

dns test: improve tests by teardown the server and upstream#43711

Merged
botengyao merged 1 commit intoenvoyproxy:mainfrom
botengyao:fix-dns-filter-tsan
Mar 2, 2026
Merged

dns test: improve tests by teardown the server and upstream#43711
botengyao merged 1 commit intoenvoyproxy:mainfrom
botengyao:fix-dns-filter-tsan

Conversation

@botengyao
Copy link
Copy Markdown
Member

@botengyao botengyao commented Mar 2, 2026

TearDown before the mock_os_sys_calls_

Risk: low

Signed-off-by: Boteng Yao <boteng@google.com>
@botengyao botengyao changed the title dns test: improve tests by shutdown the server and upstream dns test: improve tests by teardown the server and upstream Mar 2, 2026
@yanjunxiang-google
Copy link
Copy Markdown
Contributor

LGTM

@yanjunxiang-google
Copy link
Copy Markdown
Contributor

yanjunxiang-google commented Mar 2, 2026

Just curious, do we have an issue in this integration test? And does the change fix that issue?

Copy link
Copy Markdown
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@botengyao botengyao merged commit f2b8ccb into envoyproxy:main Mar 2, 2026
29 checks passed
@botengyao botengyao deleted the fix-dns-filter-tsan branch March 3, 2026 03:23
bmjask pushed a commit to bmjask/envoy that referenced this pull request Mar 14, 2026
…xy#43711)

Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle pushed a commit to bvandewalle/envoy that referenced this pull request Mar 17, 2026
phlax pushed a commit to phlax/envoy that referenced this pull request Apr 27, 2026
phlax pushed a commit that referenced this pull request Apr 27, 2026
This was referenced Apr 27, 2026
Copilot AI pushed a commit that referenced this pull request Apr 27, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Apr 27, 2026
phlax added a commit to phlax/envoy that referenced this pull request Apr 29, 2026
phlax added a commit that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants