sds/dns: fix late SDS exception throw during c-ares callbacks.#4377
Merged
Conversation
Previously, we only validated local info in SDS initialize(), which could happen during c-ares resolution. This is too late to be throwing config validation exceptions, so instead do it at SdsApi construction time. Also, make sure we safely copy exception info for EnvoyExceptions; for libc++ in oss-fuzz, attempting to copy/throw the exception in the post() was causing UBSAN failures. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10262. Risk level: Low Testing: Corpus entry added. Signed-off-by: Harvey Tuch <htuch@google.com>
zuercher
approved these changes
Sep 10, 2018
htuch
added a commit
to htuch/envoy
that referenced
this pull request
May 15, 2020
Redux of envoyproxy#4377. Fixes envoyproxy#10976 Risk level: Low Testing: Unit/integration test added. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only validated local info in SDS initialize(), which could happen during c-ares
resolution. This is too late to be throwing config validation exceptions, so instead do it at SdsApi
construction time.
Also, make sure we safely copy exception info for EnvoyExceptions; for libc++ in oss-fuzz,
attempting to copy/throw the exception in the post() was causing UBSAN failures.
Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10262.
Risk level: Low
Testing: Corpus entry added.
Signed-off-by: Harvey Tuch htuch@google.com