Add enriching metadata for HDS response #43804
Merged
Merged
Conversation
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
mathetake
changed the title
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
|
cc @wbpcode Gentle ping for a review on this. |
Contributor
|
@wbpcode re-ping for "stalled" bit. |
paul-r-gall
requested changes
Mar 19, 2026
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Member
Author
|
/retest |
Member
Author
|
@wbpcode could you take a look 🙏 |
wbpcode
previously approved these changes
Mar 24, 2026
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this contribution. Although I don't think adding new field to host is preferred, but seems for now, there is no better solution.
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
wbpcode
approved these changes
Mar 24, 2026
Member
Author
|
@paul-r-gall could you stamp? |
botengyao
approved these changes
Mar 24, 2026
paul-r-gall
approved these changes
Mar 26, 2026
TAOXUY
pushed a commit
to TAOXUY/envoy
that referenced
this pull request
Apr 1, 2026
Commit Message: Add enriching metadata for HDS response Additional Description: This adds a new field to store metadata in HDS response where we can serve more rich information back to the control plane. Currently, only HealthStatus is provided to the endpoint status Risk Level: low Testing: done Docs Changes: done in API Release Notes: Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Xuyang Tao <taoxuy@google.com>
citrus7
pushed a commit
to citrus7/envoy
that referenced
this pull request
Apr 1, 2026
Commit Message: Add enriching metadata for HDS response Additional Description: This adds a new field to store metadata in HDS response where we can serve more rich information back to the control plane. Currently, only HealthStatus is provided to the endpoint status Risk Level: low Testing: done Docs Changes: done in API Release Notes: Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Jonathan Wu <jtwu@google.com>
nshipilov
pushed a commit
to nshipilov/envoy
that referenced
this pull request
Apr 13, 2026
Commit Message: Add enriching metadata for HDS response Additional Description: This adds a new field to store metadata in HDS response where we can serve more rich information back to the control plane. Currently, only HealthStatus is provided to the endpoint status Risk Level: low Testing: done Docs Changes: done in API Release Notes: Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
Commit Message: Add enriching metadata for HDS response Additional Description: This adds a new field to store metadata in HDS response where we can serve more rich information back to the control plane. Currently, only HealthStatus is provided to the endpoint status Risk Level: low Testing: done Docs Changes: done in API Release Notes: Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add enriching metadata for HDS response
Additional Description:
This adds a new field to store metadata in HDS response where we can serve more rich information back to the control plane. Currently, only HealthStatus is provided to the endpoint status
Risk Level: low
Testing: done
Docs Changes: done in API
Release Notes:
Platform Specific Features: n/a