Skip to content

dynamic_modules: add a new extension for tracing#44024

Merged
mathetake merged 3 commits into
envoyproxy:mainfrom
agrawroh:feat-dm-tracing
Mar 27, 2026
Merged

dynamic_modules: add a new extension for tracing#44024
mathetake merged 3 commits into
envoyproxy:mainfrom
agrawroh:feat-dm-tracing

Conversation

@agrawroh
Copy link
Copy Markdown
Member

Description

This PR adds a new Dynamic Modules extension for Tracing.


Commit Message: dynamic_modules: add a new extension for tracing
Additional Description: Added a new Dynamic Modules extension for Tracing.
Risk Level: Low
Testing: Added Tests
Docs Changes: Added
Release Notes: Added

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44024 was opened by agrawroh.

see: more, trace.

@agrawroh agrawroh force-pushed the feat-dm-tracing branch 4 times, most recently from 716747b to 1df9c6d Compare March 22, 2026 18:49
@agrawroh agrawroh marked this pull request as ready for review March 22, 2026 19:23
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #44024 was ready_for_review by agrawroh.

see: more, trace.

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM overall except one comment to the ABI. :)

/wait

Comment thread source/extensions/dynamic_modules/abi/abi.h
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@mathetake mathetake merged commit a2fe7fb into envoyproxy:main Mar 27, 2026
30 checks passed
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Apr 1, 2026
## Description

This PR adds a new Dynamic Modules extension for Tracing.

---

**Commit Message:** dynamic_modules: add a new extension for tracing
**Additional Description:** Added a new Dynamic Modules extension for
Tracing.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** Added
**Release Notes:** Added

---------

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
citrus7 pushed a commit to citrus7/envoy that referenced this pull request Apr 1, 2026
## Description

This PR adds a new Dynamic Modules extension for Tracing.

---

**Commit Message:** dynamic_modules: add a new extension for tracing
**Additional Description:** Added a new Dynamic Modules extension for
Tracing.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** Added
**Release Notes:** Added

---------

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
nshipilov pushed a commit to nshipilov/envoy that referenced this pull request Apr 13, 2026
## Description

This PR adds a new Dynamic Modules extension for Tracing.

---

**Commit Message:** dynamic_modules: add a new extension for tracing
**Additional Description:** Added a new Dynamic Modules extension for
Tracing.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** Added
**Release Notes:** Added

---------

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu pushed a commit to grnmeira/envoy that referenced this pull request Apr 20, 2026
## Description

This PR adds a new Dynamic Modules extension for Tracing.

---

**Commit Message:** dynamic_modules: add a new extension for tracing
**Additional Description:** Added a new Dynamic Modules extension for
Tracing.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** Added
**Release Notes:** Added

---------

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants