stream info: prefer reference rather than shared pointer for virtualhost()#44046
Merged
wbpcode merged 2 commits intoMar 24, 2026
Merged
Conversation
…ost() Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
requested review from
mattklein123,
nezdolik and
ravenblackx
as code owners
wbpcode
assigned
ravenblackx,
yanavlasov,
ggreenway,
nezdolik and
botengyao and unassigned
yanavlasov
Member
Author
|
/retest |
ggreenway
previously approved these changes
Mar 20, 2026
|
|
||
| const Router::VirtualHostConstSharedPtr& virtualHost() const override { return vhost_; } | ||
| OptRef<const Router::VirtualHost> virtualHost() const override { | ||
| return makeOptRefFromPtr<const Router::VirtualHost>(vhost_.get()); |
Member
There was a problem hiding this comment.
Maybe OptRef should have a constructor for shared_ptr<T> to remove some boilerplate? Or maybe makeOptRefFromPtr should take the shared_ptr? Then we could remove the .get(). Just an idea; not required.
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Member
Author
|
/retest |
ravenblackx
approved these changes
Mar 23, 2026
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…ost() (envoyproxy#44046) Commit Message: stream info: prefer reference rather than shared pointer for virtualhost() Additional Description: See envoyproxy#44025 for our new style. Risk Level: n/a. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
TAOXUY
pushed a commit
to TAOXUY/envoy
that referenced
this pull request
Apr 1, 2026
…ost() (envoyproxy#44046) Commit Message: stream info: prefer reference rather than shared pointer for virtualhost() Additional Description: See envoyproxy#44025 for our new style. Risk Level: n/a. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: Xuyang Tao <taoxuy@google.com>
citrus7
pushed a commit
to citrus7/envoy
that referenced
this pull request
Apr 1, 2026
…ost() (envoyproxy#44046) Commit Message: stream info: prefer reference rather than shared pointer for virtualhost() Additional Description: See envoyproxy#44025 for our new style. Risk Level: n/a. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: Jonathan Wu <jtwu@google.com>
nshipilov
pushed a commit
to nshipilov/envoy
that referenced
this pull request
Apr 13, 2026
…ost() (envoyproxy#44046) Commit Message: stream info: prefer reference rather than shared pointer for virtualhost() Additional Description: See envoyproxy#44025 for our new style. Risk Level: n/a. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…ost() (envoyproxy#44046) Commit Message: stream info: prefer reference rather than shared pointer for virtualhost() Additional Description: See envoyproxy#44025 for our new style. Risk Level: n/a. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: stream info: prefer reference rather than shared pointer for virtualhost()
Additional Description:
See #44025 for our new style.
Risk Level: n/a.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.