Adds comptime option to link jemalloc instead of tcmalloc by mathetake · Pull Request #44113 · envoyproxy/envoy

mathetake · 2026-03-25T23:14:05Z

Commit Message: Adds comptime option to link jemalloc instead of tcmalloc
Additional Description:

This adds a new comptime option to use jemalloc instead of tcmalloc.

Risk Level: none (not enabled by default)
Testing: existing tests are run on comptime option CI
Docs Changes: follow up once it becomes stable
Release Notes: n/a
Platform Specific Features: n/a

I declare that this is mostly written by Claude with some guidance from me on how to test on CI.

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

repokitteh-read-only · 2026-03-25T23:14:11Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44113 was opened by mathetake.

see: more, trace.

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

mathetake · 2026-03-26T15:23:26Z

 build:compile-time-options --define=log_debug_assert_in_release=enabled
 build:compile-time-options --define=path_normalization_by_default=true
 build:compile-time-options --define=deprecated_features=disabled
-build:compile-time-options --define=tcmalloc=gperftools


this is to be able to run jemalloc enabled tests since gperftools will conflict with jemalloc. Instead, added gperftools option explicitly in the CI script

mathetake · 2026-03-26T15:25:01Z

+  // Purge all arenas to release dirty pages back to the OS.
+  // MALLCTL_ARENAS_ALL is jemalloc's pseudo-index for addressing all arenas at once.
+  char purge_cmd[32];
+  snprintf(purge_cmd, sizeof(purge_cmd), "arena.%u.purge", MALLCTL_ARENAS_ALL);
+  mallctl(purge_cmd, nullptr, nullptr, nullptr, 0);


this is the only place I need to learn things more about jemalloc, but it looks correct too me

repokitteh-read-only · 2026-03-26T15:25:58Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @jwendell

🐱

Caused by: #44113 was ready_for_review by mathetake.

see: more, trace.

ggreenway · 2026-03-26T15:42:09Z

 lyft
 maglev
 malloc
+mallctl


These don't need to be in the dictionary. But backticks around them in comments. Same for jemalloc above

I would keep jemalloc as tcmalloc exists here - removing others

kyessenov · 2026-03-26T17:29:50Z

 )

+bool_flag(
+    name = "jemalloc",


Should it be tcmalloc=jemalloc instead for consistency with gperftools?

yeah i did that initially, and thought it's just weird. Either works for me but will leave it to @phlax for the final call

you can use a string_flag similar to how the define works - ie something like --//bazel:alloc=jemalloc/tcmalloc

i would rather keep the bool flag as is for this PR, then refactor the flags in a follow. wdyt?

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

mathetake · 2026-03-27T03:03:19Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces support for the jemalloc memory allocator as an alternative to tcmalloc. It includes the necessary Bazel build configurations, dependency management, and CI updates to enable jemalloc. Additionally, it implements memory statistics and heap management utilities for jemalloc within the Envoy codebase. The review feedback highlights several instances where a call to refreshJemallocEpoch() is required before querying jemalloc statistics to ensure the returned values are up-to-date, and suggests using stats.mapped instead of stats.resident for consistency with existing memory reservation metrics.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

mathetake · 2026-03-27T03:41:25Z

ok i think ready

phlax · 2026-03-27T11:41:33Z

/retest possible flakes

mathetake · 2026-03-28T00:44:26Z

Good to go ?

phlax

lgtm, thanks @mathetake - sorry - i thought i approved

…#44113) Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Xuyang Tao <taoxuy@google.com>

…#44113) Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jonathan Wu <jtwu@google.com>

…#44113) Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>

…#44113) Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Adds comptime option to link jemalloc instead of tcmalloc

d9431fe

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

mathetake added 7 commits March 25, 2026 23:14

more

d51084e

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

Mutual exclusive

2c544c3

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

format

12e17f5

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

more

52b5051

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

more

8cb983c

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

ci

f9d450c

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

more

b0eb002

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

mathetake commented Mar 26, 2026

View reviewed changes

repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Mar 26, 2026

mathetake commented Mar 26, 2026

View reviewed changes

mathetake marked this pull request as ready for review March 26, 2026 15:25

mathetake requested review from agrawroh, jwendell and phlax as code owners March 26, 2026 15:25

repokitteh-read-only Bot assigned jwendell Mar 26, 2026

ggreenway reviewed Mar 26, 2026

View reviewed changes

Comment thread ci/do_ci.sh

ggreenway reviewed Mar 26, 2026

View reviewed changes

phlax reviewed Mar 26, 2026

View reviewed changes

Comment thread bazel/foreign_cc/BUILD

kyessenov reviewed Mar 26, 2026

View reviewed changes

mathetake added 3 commits March 26, 2026 19:14

reviews

e44c0c3

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

Merge remote-tracking branch 'origin/main' into jemalloc

ebcafce

spelling

45373e2

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>

gemini-code-assist Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread source/common/memory/stats.cc Outdated

Comment thread source/common/memory/stats.cc

Comment thread source/common/memory/stats.cc

Comment thread source/common/memory/stats.cc

mathetake and others added 3 commits March 26, 2026 20:15

Update source/common/memory/stats.cc

645e908

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

Update source/common/memory/stats.cc

cee0753

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

Update source/common/memory/stats.cc

e3ba951

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

Update source/common/memory/stats.cc

b0cff72

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>

phlax reviewed Mar 28, 2026

View reviewed changes

phlax approved these changes Mar 28, 2026

View reviewed changes

repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 28, 2026

phlax merged commit 810f3ed into envoyproxy:main Mar 28, 2026
34 checks passed

Conversation

mathetake commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Mar 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

repokitteh-read-only Bot commented Mar 26, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mathetake commented Mar 27, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathetake commented Mar 27, 2026

Uh oh!

phlax commented Mar 27, 2026

Uh oh!

mathetake commented Mar 28, 2026

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mathetake commented Mar 25, 2026 •

edited

Loading