dym: make EnvoyBuffer easier to use in test#44130
Merged
mathetake merged 3 commits intoMar 26, 2026
Merged
Conversation
mathetake
requested review from
agrawroh,
mattklein123 and
wbpcode
as code owners
mathetake
commented
Mar 26, 2026
Contributor
|
I'm trying to understand how this is working. It looks like the lifetime parameters are always the same? The problem I thought we were seeing was that |
mathetake
force-pushed
the
envoysdkenvoybufferlifetime
branch
from
8760a56 to
1bee921
Compare
Member
Author
|
@akonradi PTAL - reworked the PR |
akonradi
reviewed
Mar 26, 2026
akonradi
approved these changes
Mar 26, 2026
Contributor
akonradi
left a comment
akonradi
left a comment
There was a problem hiding this comment.
Just the one request, otherwise looks great!
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
agrawroh
approved these changes
Mar 26, 2026
TAOXUY
pushed a commit
to TAOXUY/envoy
that referenced
this pull request
Apr 1, 2026
Commit Message: dym: make EnvoyBuffer easier to use in test Additional Description: Risk Level: none (only impacts unit tests with mocks) Testing: done Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Xuyang Tao <taoxuy@google.com>
citrus7
pushed a commit
to citrus7/envoy
that referenced
this pull request
Apr 1, 2026
Commit Message: dym: make EnvoyBuffer easier to use in test Additional Description: Risk Level: none (only impacts unit tests with mocks) Testing: done Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Jonathan Wu <jtwu@google.com>
nshipilov
pushed a commit
to nshipilov/envoy
that referenced
this pull request
Apr 13, 2026
Commit Message: dym: make EnvoyBuffer easier to use in test Additional Description: Risk Level: none (only impacts unit tests with mocks) Testing: done Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
Commit Message: dym: make EnvoyBuffer easier to use in test Additional Description: Risk Level: none (only impacts unit tests with mocks) Testing: done Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dym: make EnvoyBuffer easier to use in test
Additional Description:
Risk Level: none (only impacts unit tests with mocks)
Testing: done
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a