Skip to content

Ensure rusftfmt executed on all *.rs#44131

Merged
mathetake merged 2 commits intoenvoyproxy:mainfrom
mathetake:cargofmtci
Mar 26, 2026
Merged

Ensure rusftfmt executed on all *.rs#44131
mathetake merged 2 commits intoenvoyproxy:mainfrom
mathetake:cargofmtci

Conversation

@mathetake
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44131 was opened by mathetake.

see: more, trace.

@mathetake mathetake marked this pull request as ready for review March 26, 2026 20:21
@mathetake mathetake requested a review from phlax March 26, 2026 20:21
agrawroh
agrawroh previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
@mathetake mathetake merged commit c04b28b into envoyproxy:main Mar 26, 2026
29 checks passed
@mathetake mathetake deleted the cargofmtci branch March 26, 2026 21:57
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Apr 1, 2026
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
citrus7 pushed a commit to citrus7/envoy that referenced this pull request Apr 1, 2026
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
eric846 pushed a commit to envoyproxy/nighthawk that referenced this pull request Apr 11, 2026
- Update NH to the latest Envoy.
- Implement `initManager` in `source/client/process_impl.cc` to accommodate envoyproxy/envoy#44100.
- Include a `--path` argument to `tools/check_format.sh` to resolve a Bazel failure after running the newly added rust format check in envoyproxy/envoy#44131.
- Skip assertion in `source/client/flush_worker_impl.cc` as a workaround to accommodate the newly introduced assertion in envoyproxy/envoy#44015.

Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: Jason Ye <jiajunye@google.com>
nshipilov pushed a commit to nshipilov/envoy that referenced this pull request Apr 13, 2026
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants